| Message ID | 20200912224431.1428-17-luoyonggang@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | W32, W64 msys2/mingw patches | expand |
On 13/09/2020 00.44, Yonggang Luo wrote: > This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba > ("cirrus.yml: Split FreeBSD job into two parts"). > > freebsd 1 hour limit not hit anymore > > I think we going to a wrong direction, I think there is some tests a stall the test runner, > please look at > https://cirrus-ci.com/task/5110577531977728 > When its running properly, the consumed time are little, but when tests running too long, > look at the cpu usage, the cpu usage are nearly zero. doesn't consuming time. > > And look at > https://cirrus-ci.com/task/6119341601062912 > > If the tests running properly, the time consuming are little > We should not hide the error by split them > > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > Reviewed-by: Ed Maste <emaste@FreeBSD.org> > --- > .cirrus.yml | 35 ++++++++--------------------------- > 1 file changed, 8 insertions(+), 27 deletions(-) I tried this a couple of times now, and currently the problem seems to be gone, indeed. I'd still prefer to understand first why we have seen the slowdown a couple of weeks ago, but if people agree that we should revert the patch now, that's ok for me now, too. Tested-by: Thomas Huth <thuth@redhat.com>
On 9/14/20 9:27 AM, Thomas Huth wrote: > On 13/09/2020 00.44, Yonggang Luo wrote: >> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba >> ("cirrus.yml: Split FreeBSD job into two parts"). >> >> freebsd 1 hour limit not hit anymore >> >> I think we going to a wrong direction, I think there is some tests a stall the test runner, >> please look at >> https://cirrus-ci.com/task/5110577531977728 >> When its running properly, the consumed time are little, but when tests running too long, >> look at the cpu usage, the cpu usage are nearly zero. doesn't consuming time. >> >> And look at >> https://cirrus-ci.com/task/6119341601062912 >> >> If the tests running properly, the time consuming are little >> We should not hide the error by split them >> >> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> >> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> >> Reviewed-by: Ed Maste <emaste@FreeBSD.org> >> --- >> .cirrus.yml | 35 ++++++++--------------------------- >> 1 file changed, 8 insertions(+), 27 deletions(-) > > I tried this a couple of times now, and currently the problem seems to > be gone, indeed. I'd still prefer to understand first why we have seen > the slowdown a couple of weeks ago, but if people agree that we should > revert the patch now, that's ok for me now, too. Not sure if related (probably not as failure and not timeout), I hit this during the night: TEST iotest-qcow2: 030 [fail] QEMU -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-system-alpha" -nodefaults -display none -accel qtest QEMU_IMG -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-img" QEMU_IO -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-io" --cache writeback --aio threads -f qcow2 QEMU_NBD -- "/tmp/cirrus-ci-build/build/tests/qemu-iotests/../../qemu-nbd" IMGFMT -- qcow2 (compat=1.1) IMGPROTO -- file PLATFORM -- FreeBSD/amd64 cirrus-task-6204750985166848 12.1-RELEASE TEST_DIR -- /tmp/cirrus-ci-build/build/tests/qemu-iotests/scratch SOCK_DIR -- /tmp/tmp.VuwmKXUW SOCKET_SCM_HELPER -- --- /tmp/cirrus-ci-build/tests/qemu-iotests/030.out 2020-09-13 21:08:32.261276000 +0000 +++ /tmp/cirrus-ci-build/build/tests/qemu-iotests/030.out.bad 2020-09-13 21:30:59.736699000 +0000 @@ -1,5 +1,17 @@ -........................... +.............F............. +====================================================================== +FAIL: test_stream_parallel (__main__.TestParallelOps) ---------------------------------------------------------------------- +Traceback (most recent call last): + File "030", line 251, in test_stream_parallel + self.assert_qmp(result, 'return', {}) + File "/tmp/cirrus-ci-build/tests/qemu-iotests/iotests.py", line 888, in assert_qmp + result = self.dictpath(d, path) + File "/tmp/cirrus-ci-build/tests/qemu-iotests/iotests.py", line 862, in dictpath + self.fail(f'failed path traversal for "{path}" in "{d}"') +AssertionError: failed path traversal for "return" in "{'error': {'class': 'DeviceNotActive', 'desc': "Block job 'stream-node8' not found"}}" + +---------------------------------------------------------------------- Failures: 030 Failed 1 of 74 iotests gmake[1]: *** [/tmp/cirrus-ci-build/tests/Makefile.include:144: check-block] Error 1 gmake[1]: Leaving directory '/tmp/cirrus-ci-build/build' https://cirrus-ci.com/task/6204750985166848
On 14/09/2020 10.50, Philippe Mathieu-Daudé wrote: > On 9/14/20 9:27 AM, Thomas Huth wrote: >> On 13/09/2020 00.44, Yonggang Luo wrote: >>> This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba >>> ("cirrus.yml: Split FreeBSD job into two parts"). >>> >>> freebsd 1 hour limit not hit anymore >>> >>> I think we going to a wrong direction, I think there is some tests a stall the test runner, >>> please look at >>> https://cirrus-ci.com/task/5110577531977728 >>> When its running properly, the consumed time are little, but when tests running too long, >>> look at the cpu usage, the cpu usage are nearly zero. doesn't consuming time. >>> >>> And look at >>> https://cirrus-ci.com/task/6119341601062912 >>> >>> If the tests running properly, the time consuming are little >>> We should not hide the error by split them >>> >>> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> >>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> >>> Reviewed-by: Ed Maste <emaste@FreeBSD.org> >>> --- >>> .cirrus.yml | 35 ++++++++--------------------------- >>> 1 file changed, 8 insertions(+), 27 deletions(-) >> >> I tried this a couple of times now, and currently the problem seems to >> be gone, indeed. I'd still prefer to understand first why we have seen >> the slowdown a couple of weeks ago, but if people agree that we should >> revert the patch now, that's ok for me now, too. > > Not sure if related (probably not as failure and not timeout), > I hit this during the night: > > TEST iotest-qcow2: 030 [fail] No, that's a different (known) issue. See my patch on the list: [PATCH v2] iotests: Skip test_stream_parallel in test 030 when doing "make check" Thomas
diff --git a/.cirrus.yml b/.cirrus.yml index 3dd9fcff7f..690c6882e8 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -1,38 +1,19 @@ env: CIRRUS_CLONE_DEPTH: 1 -freebsd_1st_task: +freebsd_12_task: freebsd_instance: image_family: freebsd-12-1 - cpu: 4 - memory: 4G - install_script: ASSUME_ALWAYS_YES=yes pkg bootstrap -f ; pkg install -y - bash curl cyrus-sasl git glib gmake gnutls gsed - nettle perl5 pixman pkgconf png usbredir + cpu: 8 + memory: 8G + install_script: + - ASSUME_ALWAYS_YES=yes pkg bootstrap -f ; + - pkg install -y bash curl cyrus-sasl git glib gmake gnutls gsed + nettle perl5 pixman pkgconf png usbredir script: - mkdir build - cd build - - ../configure --disable-user --target-list-exclude='alpha-softmmu - ppc64-softmmu ppc-softmmu riscv32-softmmu riscv64-softmmu s390x-softmmu - sparc64-softmmu sparc-softmmu x86_64-softmmu i386-softmmu' - --enable-werror || { cat config.log; exit 1; } - - gmake -j$(sysctl -n hw.ncpu) - - gmake -j$(sysctl -n hw.ncpu) check - -freebsd_2nd_task: - freebsd_instance: - image_family: freebsd-12-1 - cpu: 4 - memory: 4G - install_script: ASSUME_ALWAYS_YES=yes pkg bootstrap -f ; pkg install -y - bash curl cyrus-sasl git glib gmake gnutls gtk3 gsed libepoxy mesa-libs - nettle perl5 pixman pkgconf png SDL2 usbredir - script: - - ./configure --enable-werror --target-list='alpha-softmmu ppc64-softmmu - ppc-softmmu riscv32-softmmu riscv64-softmmu s390x-softmmu - sparc64-softmmu sparc-softmmu x86_64-softmmu i386-softmmu - sparc-bsd-user sparc64-bsd-user x86_64-bsd-user i386-bsd-user' - || { cat config.log; exit 1; } + - ../configure --enable-werror || { cat config.log; exit 1; } - gmake -j$(sysctl -n hw.ncpu) - gmake -j$(sysctl -n hw.ncpu) check
This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba ("cirrus.yml: Split FreeBSD job into two parts"). freebsd 1 hour limit not hit anymore I think we going to a wrong direction, I think there is some tests a stall the test runner, please look at https://cirrus-ci.com/task/5110577531977728 When its running properly, the consumed time are little, but when tests running too long, look at the cpu usage, the cpu usage are nearly zero. doesn't consuming time. And look at https://cirrus-ci.com/task/6119341601062912 If the tests running properly, the time consuming are little We should not hide the error by split them Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Ed Maste <emaste@FreeBSD.org> --- .cirrus.yml | 35 ++++++++--------------------------- 1 file changed, 8 insertions(+), 27 deletions(-)