diff mbox series

qemu-edid: drop cast

Message ID 20201013091615.14166-1-kraxel@redhat.com
State New, archived
Headers show
Series qemu-edid: drop cast | expand

Commit Message

Gerd Hoffmann Oct. 13, 2020, 9:16 a.m. UTC
Not needed and makes some compilers error out with:

qemu-edid.c:15:1: error: initializer element is not constant

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-edid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel P. Berrangé Oct. 13, 2020, 9:23 a.m. UTC | #1
On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote:
> Not needed and makes some compilers error out with:
> 
> qemu-edid.c:15:1: error: initializer element is not constant

Which compilers do this. If we're not seeing this failure in our
CI, then we have a CI gap that likely needs filling.

> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-edid.c b/qemu-edid.c
> index 1db3372b982c..1cd6a9517238 100644
> --- a/qemu-edid.c
> +++ b/qemu-edid.c
> @@ -9,7 +9,7 @@
>  #include "qemu/cutils.h"
>  #include "hw/display/edid.h"
>  
> -static qemu_edid_info info = (qemu_edid_info) {
> +static qemu_edid_info info = {
>      .prefx = 1024,
>      .prefy = 768,
>  };
> -- 
> 2.27.0
> 
> 

Regards,
Daniel
Gerd Hoffmann Oct. 13, 2020, 10:34 a.m. UTC | #2
On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote:
> On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote:
> > Not needed and makes some compilers error out with:
> > 
> > qemu-edid.c:15:1: error: initializer element is not constant
> 
> Which compilers do this. If we're not seeing this failure in our
> CI, then we have a CI gap that likely needs filling.

x86_64-w64-mingw32-gcc (GCC) 4.9.3 20150626 (Fedora MinGW 4.9.3-1.el7)

take care,
  Gerd
Daniel P. Berrangé Oct. 13, 2020, 10:40 a.m. UTC | #3
On Tue, Oct 13, 2020 at 12:34:46PM +0200, Gerd Hoffmann wrote:
> On Tue, Oct 13, 2020 at 10:23:22AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote:
> > > Not needed and makes some compilers error out with:
> > > 
> > > qemu-edid.c:15:1: error: initializer element is not constant
> > 
> > Which compilers do this. If we're not seeing this failure in our
> > CI, then we have a CI gap that likely needs filling.
> 
> x86_64-w64-mingw32-gcc (GCC) 4.9.3 20150626 (Fedora MinGW 4.9.3-1.el7)

Oh, that's a really ancient mingw toolchain.  Officially we only care
about current generation mingw toolchains ad don't try to support old
ones. Effectively this means whatever mingw is in current shipping
Fedora or MXE releases.

The fix is fine, but we don't need to worry about adding this CI after
all since its an unsupported platform.

Regards,
Daniel
Daniel P. Berrangé Oct. 13, 2020, 10:41 a.m. UTC | #4
On Tue, Oct 13, 2020 at 11:16:15AM +0200, Gerd Hoffmann wrote:
> Not needed and makes some compilers error out with:
> 
> qemu-edid.c:15:1: error: initializer element is not constant
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-edid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-edid.c b/qemu-edid.c
> index 1db3372b982c..1cd6a9517238 100644
> --- a/qemu-edid.c
> +++ b/qemu-edid.c
> @@ -9,7 +9,7 @@
>  #include "qemu/cutils.h"
>  #include "hw/display/edid.h"
>  
> -static qemu_edid_info info = (qemu_edid_info) {
> +static qemu_edid_info info = {
>      .prefx = 1024,
>      .prefy = 768,
>  };

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
diff mbox series

Patch

diff --git a/qemu-edid.c b/qemu-edid.c
index 1db3372b982c..1cd6a9517238 100644
--- a/qemu-edid.c
+++ b/qemu-edid.c
@@ -9,7 +9,7 @@ 
 #include "qemu/cutils.h"
 #include "hw/display/edid.h"
 
-static qemu_edid_info info = (qemu_edid_info) {
+static qemu_edid_info info = {
     .prefx = 1024,
     .prefy = 768,
 };