Message ID | 20201027114438.17662-1-peter.maydell@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Patchew URL: https://patchew.org/QEMU/20201027114438.17662-1-peter.maydell@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201027114438.17662-1-peter.maydell@linaro.org Subject: [PULL 00/48] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201027050556.269064-1-eblake@redhat.com -> patchew/20201027050556.269064-1-eblake@redhat.com * [new tag] patchew/20201027114438.17662-1-peter.maydell@linaro.org -> patchew/20201027114438.17662-1-peter.maydell@linaro.org - [tag update] patchew/20201027121026.3025930-1-armbru@redhat.com -> patchew/20201027121026.3025930-1-armbru@redhat.com Switched to a new branch 'test' 7ba5fb5 hw/timer/armv7m_systick: Rewrite to use ptimers 800707e hw/core/ptimer: Support ptimer being disabled by timer callback b2dcb2c hw/arm/sbsa-ref: add SBSA watchdog device b0d5f47 hw/watchdog: Implement SBSA watchdog device 87e917b hw/arm/bcm2835_peripherals: connect the UART clock 59bad7c hw/char/pl011: add a clock input 4df2b99 hw/misc/bcm2835_cprman: add sane reset values to the registers 3ace683 hw/misc/bcm2835_cprman: add the DSI0HSCK multiplexer 95da725 hw/misc/bcm2835_cprman: implement clock mux behaviour 2c72081 hw/misc/bcm2835_cprman: add a clock mux skeleton implementation 886fcae hw/misc/bcm2835_cprman: implement PLL channels behaviour 0b6298f hw/misc/bcm2835_cprman: add a PLL channel skeleton implementation 0db49d0 hw/misc/bcm2835_cprman: implement PLLs behaviour 839d467 hw/misc/bcm2835_cprman: add a PLL skeleton implementation 77ccdb3 hw/arm/raspi: add a skeleton implementation of the CPRMAN 1fc5050 hw/arm/raspi: fix CPRMAN base address 0fab2eb hw/core/clock: trace clock values in Hz instead of ns 278d7cf hw/core/clock: provide the VMSTATE_ARRAY_CLOCK macro e58d1c5 arm/trace: Fix hex printing 33f1093 hw/arm/raspi: Add the Raspberry Pi 3 model A+ 32a9291 hw/arm/raspi: Add the Raspberry Pi Zero machine 4c466cd hw/arm/raspi: Add the Raspberry Pi A+ machine e254a9e hw/arm/bcm2836: Introduce the BCM2835 SoC 8fdc526 hw/arm/bcm2836: Split out common realize() code 17f574c hw/arm/bcm2836: Only provide "enabled-cpus" property to multicore SoCs 5ab600e hw/arm/bcm2836: Introduce BCM283XClass::core_count 3b586d0 hw/arm/bcm2836: QOM'ify more by adding class_init() to each SoC type 1a67971 hw/arm/bcm2836: Restrict BCM283XInfo declaration to C source 46fa382 hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly 003ff63 hw/gpio: Add GPIO model for Nuvoton NPCM7xx ce89011 hw/arm/npcm7xx: Add EHCI and OHCI controllers 1fe4947 hw/misc: Add npcm7xx random number generator f637867 hw/timer: Adding watchdog for NPCM7XX Timer. 16d794c Move npcm7xx_timer_reached_zero call out of npcm7xx_timer_pause 45c3f54 hw/arm: fix min_cpus for xlnx-versal-virt platform f640159 hw/arm/highbank: Silence warnings about missing fallthrough statements 7d43063 tests/tcg/aarch64: Add bti smoke tests 4208653 linux-user/elfload: Parse GNU_PROPERTY_AARCH64_FEATURE_1_AND 9bbc9de linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes 92fab30 linux-user/elfload: Use Error for load_elf_interp 648b887 linux-user/elfload: Use Error for load_elf_image 0765334 linux-user/elfload: Move PT_INTERP detection to first loop 1839436 linux-user/elfload: Adjust iteration over phdr b450ca7 linux-user/elfload: Fix coding style in load_elf_image 1a82d93 linux-user/elfload: Avoid leaking interp_name using GLib memory API 2155d6e include/elf: Add defines related to GNU property notes for AArch64 f2fa4ed linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI 78aceda linux-user/aarch64: Reset btype for signals === OUTPUT BEGIN === 1/48 Checking commit 78aceda6b875 (linux-user/aarch64: Reset btype for signals) 2/48 Checking commit f2fa4edfcc6d (linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI) 3/48 Checking commit 2155d6ec64ba (include/elf: Add defines related to GNU property notes for AArch64) 4/48 Checking commit 1a82d93cf9e0 (linux-user/elfload: Avoid leaking interp_name using GLib memory API) 5/48 Checking commit b450ca78d35a (linux-user/elfload: Fix coding style in load_elf_image) 6/48 Checking commit 1839436bae5a (linux-user/elfload: Adjust iteration over phdr) 7/48 Checking commit 076533472c48 (linux-user/elfload: Move PT_INTERP detection to first loop) 8/48 Checking commit 648b88760734 (linux-user/elfload: Use Error for load_elf_image) 9/48 Checking commit 92fab3002426 (linux-user/elfload: Use Error for load_elf_interp) 10/48 Checking commit 9bbc9de29365 (linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes) 11/48 Checking commit 42086532ece6 (linux-user/elfload: Parse GNU_PROPERTY_AARCH64_FEATURE_1_AND) 12/48 Checking commit 7d43063daf83 (tests/tcg/aarch64: Add bti smoke tests) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 ERROR: use qemu_real_host_page_size instead of getpagesize() #200: FILE: tests/tcg/aarch64/bti-2.c:89: + void *p = mmap(0, getpagesize(), ERROR: externs should be avoided in .c files #246: FILE: tests/tcg/aarch64/bti-crt.inc.c:13: +int main(void); total: 2 errors, 1 warnings, 255 lines checked Patch 12/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/48 Checking commit f640159a060b (hw/arm/highbank: Silence warnings about missing fallthrough statements) 14/48 Checking commit 45c3f54efeab (hw/arm: fix min_cpus for xlnx-versal-virt platform) 15/48 Checking commit 16d794c8afba (Move npcm7xx_timer_reached_zero call out of npcm7xx_timer_pause) 16/48 Checking commit f6378670f038 (hw/timer: Adding watchdog for NPCM7XX Timer.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #675: new file mode 100644 total: 0 errors, 1 warnings, 915 lines checked Patch 16/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/48 Checking commit 1fe4947ae36b (hw/misc: Add npcm7xx random number generator) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 total: 0 errors, 1 warnings, 579 lines checked Patch 17/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/48 Checking commit ce89011b5119 (hw/arm/npcm7xx: Add EHCI and OHCI controllers) 19/48 Checking commit 003ff63bdb6f (hw/gpio: Add GPIO model for Nuvoton NPCM7xx) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #164: new file mode 100644 total: 0 errors, 1 warnings, 1022 lines checked Patch 19/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/48 Checking commit 46fa38219b7e (hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly) 21/48 Checking commit 1a67971bdea8 (hw/arm/bcm2836: Restrict BCM283XInfo declaration to C source) 22/48 Checking commit 3b586d0b1c34 (hw/arm/bcm2836: QOM'ify more by adding class_init() to each SoC type) 23/48 Checking commit 5ab600e60960 (hw/arm/bcm2836: Introduce BCM283XClass::core_count) 24/48 Checking commit 17f574c3f983 (hw/arm/bcm2836: Only provide "enabled-cpus" property to multicore SoCs) 25/48 Checking commit 8fdc5268b7ab (hw/arm/bcm2836: Split out common realize() code) 26/48 Checking commit e254a9e48b37 (hw/arm/bcm2836: Introduce the BCM2835 SoC) 27/48 Checking commit 4c466cd6957a (hw/arm/raspi: Add the Raspberry Pi A+ machine) 28/48 Checking commit 32a9291cb659 (hw/arm/raspi: Add the Raspberry Pi Zero machine) 29/48 Checking commit 33f109382a5e (hw/arm/raspi: Add the Raspberry Pi 3 model A+) 30/48 Checking commit e58d1c59ceba (arm/trace: Fix hex printing) 31/48 Checking commit 278d7cff33fd (hw/core/clock: provide the VMSTATE_ARRAY_CLOCK macro) 32/48 Checking commit 0fab2ebcfec8 (hw/core/clock: trace clock values in Hz instead of ns) 33/48 Checking commit 1fc5050168b1 (hw/arm/raspi: fix CPRMAN base address) 34/48 Checking commit 77ccdb3da326 (hw/arm/raspi: add a skeleton implementation of the CPRMAN) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 283 lines checked Patch 34/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 35/48 Checking commit 839d4678b9aa (hw/misc/bcm2835_cprman: add a PLL skeleton implementation) 36/48 Checking commit 0db49d0b51fc (hw/misc/bcm2835_cprman: implement PLLs behaviour) 37/48 Checking commit 0b6298f8b275 (hw/misc/bcm2835_cprman: add a PLL channel skeleton implementation) 38/48 Checking commit 886fcae43c65 (hw/misc/bcm2835_cprman: implement PLL channels behaviour) 39/48 Checking commit 2c72081394c8 (hw/misc/bcm2835_cprman: add a clock mux skeleton implementation) WARNING: Block comments use a leading /* on a separate line #515: FILE: include/hw/misc/bcm2835_cprman_internals.h:428: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* gnd */ \ WARNING: Block comments use a leading /* on a separate line #516: FILE: include/hw/misc/bcm2835_cprman_internals.h:429: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* xosc */ \ WARNING: Block comments use a leading /* on a separate line #517: FILE: include/hw/misc/bcm2835_cprman_internals.h:430: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* test debug 0 */ \ WARNING: Block comments use a leading /* on a separate line #518: FILE: include/hw/misc/bcm2835_cprman_internals.h:431: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* test debug 1 */ \ WARNING: Block comments use a leading /* on a separate line #519: FILE: include/hw/misc/bcm2835_cprman_internals.h:432: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* pll a */ \ WARNING: Block comments use a leading /* on a separate line #520: FILE: include/hw/misc/bcm2835_cprman_internals.h:433: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* pll c */ \ WARNING: Block comments use a leading /* on a separate line #521: FILE: include/hw/misc/bcm2835_cprman_internals.h:434: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* pll d */ \ WARNING: Block comments use a leading /* on a separate line #522: FILE: include/hw/misc/bcm2835_cprman_internals.h:435: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* pll h */ \ WARNING: Block comments use a leading /* on a separate line #523: FILE: include/hw/misc/bcm2835_cprman_internals.h:436: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* pll c, core1 */ \ WARNING: Block comments use a leading /* on a separate line #524: FILE: include/hw/misc/bcm2835_cprman_internals.h:437: + CPRMAN_CLOCK_SRC_FORCE_GROUND, /* pll c, core2 */ \ total: 0 errors, 10 warnings, 759 lines checked Patch 39/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/48 Checking commit 95da7258ad44 (hw/misc/bcm2835_cprman: implement clock mux behaviour) 41/48 Checking commit 3ace683566e1 (hw/misc/bcm2835_cprman: add the DSI0HSCK multiplexer) 42/48 Checking commit 4df2b99ae019 (hw/misc/bcm2835_cprman: add sane reset values to the registers) 43/48 Checking commit 59bad7cc51cb (hw/char/pl011: add a clock input) 44/48 Checking commit 87e917b409cb (hw/arm/bcm2835_peripherals: connect the UART clock) 45/48 Checking commit b0d5f478641d (hw/watchdog: Implement SBSA watchdog device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 389 lines checked Patch 45/48 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 46/48 Checking commit b2dcb2cf9a16 (hw/arm/sbsa-ref: add SBSA watchdog device) 47/48 Checking commit 800707e19f40 (hw/core/ptimer: Support ptimer being disabled by timer callback) 48/48 Checking commit 7ba5fb5536d0 (hw/timer/armv7m_systick: Rewrite to use ptimers) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201027114438.17662-1-peter.maydell@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Tue, 27 Oct 2020 at 11:44, Peter Maydell <peter.maydell@linaro.org> wrote: > > Last minute pullreq for arm related patches; quite large because > there were several series that only just made it through code review > in time. > > thanks > -- PMM > > The following changes since commit 091e3e3dbc499d84c004e1c50bc9870af37f6e99: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-bitmaps-2020-10-26' into staging (2020-10-26 22:36:35 +0000) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201027-1 > > for you to fetch changes up to 32bd322a0134ed89db00f2b9b3894982db3dedcb: > > hw/timer/armv7m_systick: Rewrite to use ptimers (2020-10-27 11:15:31 +0000) > > ---------------------------------------------------------------- > target-arm queue: > * raspi: add model of cprman clock manager > * sbsa-ref: add an SBSA generic watchdog device > * arm/trace: Fix hex printing > * raspi: Add models of Pi 3 model A+, Pi Zero and Pi A+ > * hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly > * Nuvoton NPCM7xx: Add USB, RNG, GPIO and watchdog support > * hw/arm: fix min_cpus for xlnx-versal-virt platform > * hw/arm/highbank: Silence warnings about missing fallthrough statements > * linux-user: Support Aarch64 BTI > * Armv7M systick: fix corner case bugs by rewriting to use ptimer > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM