| Message ID | 20201030202131.796967-11-ehabkost@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qdev/qom: Remove explicit type names from error_setg() calls | expand |
On Fri, 30 Oct 2020 16:21:21 -0400 Eduardo Habkost <ehabkost@redhat.com> wrote: > object_property_parse() will add a > "Property '<TYPE>.<PROP>' can't take value '<VALUE>'" > prefix automatically for us. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > Cc: Eduardo Habkost <ehabkost@redhat.com> > Cc: Igor Mammedov <imammedo@redhat.com> > Cc: qemu-devel@nongnu.org > --- > backends/hostmem-memfd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c > index e5626d4330..05cf743fe8 100644 > --- a/backends/hostmem-memfd.c > +++ b/backends/hostmem-memfd.c > @@ -87,8 +87,7 @@ memfd_backend_set_hugetlbsize(Object *obj, Visitor *v, const char *name, > return; > } > if (!value) { > - error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu64 "'", > - object_get_typename(obj), name, value); > + error_setg(errp, "hugetlbsize can't be zero"); > return; > } > m->hugetlbsize = value;
diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index e5626d4330..05cf743fe8 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -87,8 +87,7 @@ memfd_backend_set_hugetlbsize(Object *obj, Visitor *v, const char *name, return; } if (!value) { - error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu64 "'", - object_get_typename(obj), name, value); + error_setg(errp, "hugetlbsize can't be zero"); return; } m->hugetlbsize = value;
object_property_parse() will add a "Property '<TYPE>.<PROP>' can't take value '<VALUE>'" prefix automatically for us. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Cc: Eduardo Habkost <ehabkost@redhat.com> Cc: Igor Mammedov <imammedo@redhat.com> Cc: qemu-devel@nongnu.org --- backends/hostmem-memfd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)