| Message ID | 20201130122538.27674-2-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qapi/qom: QAPIfy object-add | expand |
On 30/11/20 13:25, Kevin Wolf wrote: > +## > +# @IothreadProperties: > +# > +# Properties for iothread objects. > +# > +# @poll-max-ns: the maximum number of nanoseconds to busy wait for events. > +# 0 means polling is disabled (default: 32768 on POSIX hosts, > +# 0 otherwise) > +# > +# @poll-grow: the multiplier used to increase the polling time when the > +# algorithm detects it is missing events due to not polling long > +# enough. 0 selects a default behaviour (default: 0) > +# > +# @poll-shrink: the divisor used to decrease the polling time when the > +# algorithm detects it is spending too long polling without > +# encountering events. 0 selects a default behaviour (default: 0) > +# > +# Since: 6.0 > +## > +{ 'struct': 'IothreadProperties', > + 'data': { '*poll-max-ns': 'int', > + '*poll-grow': 'int', > + '*poll-shrink': 'int' } } > + Documentation is the main advantage of the ObjectOptions concept. However, please use the version where each object and property was introduced for the "since" value. Otherwise the documentation will appear to show that none of these objects was available before 6.0. Yes, there is no documentation at all right now for QOM objects. However, wrong documentation sometimes is worse than non-existing documentation. Paolo
Am 30.11.2020 um 16:00 hat Paolo Bonzini geschrieben: > On 30/11/20 13:25, Kevin Wolf wrote: > > +## > > +# @IothreadProperties: > > +# > > +# Properties for iothread objects. > > +# > > +# @poll-max-ns: the maximum number of nanoseconds to busy wait for events. > > +# 0 means polling is disabled (default: 32768 on POSIX hosts, > > +# 0 otherwise) > > +# > > +# @poll-grow: the multiplier used to increase the polling time when the > > +# algorithm detects it is missing events due to not polling long > > +# enough. 0 selects a default behaviour (default: 0) > > +# > > +# @poll-shrink: the divisor used to decrease the polling time when the > > +# algorithm detects it is spending too long polling without > > +# encountering events. 0 selects a default behaviour (default: 0) > > +# > > +# Since: 6.0 > > +## > > +{ 'struct': 'IothreadProperties', > > + 'data': { '*poll-max-ns': 'int', > > + '*poll-grow': 'int', > > + '*poll-shrink': 'int' } } > > + > > Documentation is the main advantage of the ObjectOptions concept. However, > please use the version where each object and property was introduced for the > "since" value. Otherwise the documentation will appear to show that none of > these objects was available before 6.0. > > Yes, there is no documentation at all right now for QOM objects. However, > wrong documentation sometimes is worse than non-existing documentation. I think we generally use the version when the schema was introduced (so blockdev-add has 2.9 for most things even if they existed before in -drive and drive_add), but I agree that your suggestion is more useful. And object-add isn't a new command, we're just giving it a schema now. So let's first discuss the general direction, but if we agree on that, using the version numbers where objects and properties were first introduced makes sense. Maybe if maintainers can include the right version numbers in the review of the patch for "their" object, that would help me updating the patches. Kevin
diff --git a/qapi/qom.json b/qapi/qom.json index 0b0b92944b..57d1386758 100644 --- a/qapi/qom.json +++ b/qapi/qom.json @@ -202,6 +202,59 @@ 'returns': [ 'ObjectPropertyInfo' ], 'allow-preconfig': true } +## +# @IothreadProperties: +# +# Properties for iothread objects. +# +# @poll-max-ns: the maximum number of nanoseconds to busy wait for events. +# 0 means polling is disabled (default: 32768 on POSIX hosts, +# 0 otherwise) +# +# @poll-grow: the multiplier used to increase the polling time when the +# algorithm detects it is missing events due to not polling long +# enough. 0 selects a default behaviour (default: 0) +# +# @poll-shrink: the divisor used to decrease the polling time when the +# algorithm detects it is spending too long polling without +# encountering events. 0 selects a default behaviour (default: 0) +# +# Since: 6.0 +## +{ 'struct': 'IothreadProperties', + 'data': { '*poll-max-ns': 'int', + '*poll-grow': 'int', + '*poll-shrink': 'int' } } + +## +# @ObjectType: +# +# Since: 6.0 +## +{ 'enum': 'ObjectType', + 'data': [ + 'iothread' + ] } + +## +# @ObjectOptions: +# +# Describes the options of a user creatable QOM object. +# +# @qom-type: the class name for the object to be created +# +# @id: the name of the new object +# +# Since: 6.0 +## +{ 'union': 'ObjectOptions', + 'base': { 'qom-type': 'ObjectType', + 'id': 'str' }, + 'discriminator': 'qom-type', + 'data': { + 'iothread': 'IothreadProperties' + } } + ## # @object-add: #
Add an ObjectOptions union that will eventually describe the options of all user creatable object types. As unions can't exist without any branches, also add the first object type. This adds a QAPI schema for the properties of the iothread object. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- qapi/qom.json | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+)