| Message ID | 20201202101655.122214-1-mst@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2 Dec 2020 at 11:03, Michael S. Tsirkin <mst@redhat.com> wrote: > > Patch 5 gave me pause but we do need patch 6 as > it's a guest triggerable assert, and it seemed > cleaner to just take the whole patchset than cherry-pick. Is this only "fixes a guest triggerable assert"? If so, that's not sufficiently important to require an rc5 at this point. thanks -- PMM
On Thu, Dec 03, 2020 at 10:20:03AM +0000, Peter Maydell wrote: > On Wed, 2 Dec 2020 at 11:03, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > Patch 5 gave me pause but we do need patch 6 as > > it's a guest triggerable assert, and it seemed > > cleaner to just take the whole patchset than cherry-pick. > > Is this only "fixes a guest triggerable assert"? My understanding is that without the patches a rhel7 guest triggers the assert if started with vtd enabled and virtio-net with iommu_platform=on. https://bugs.launchpad.net/qemu/+bug/1885175 > If so, that's > not sufficiently important to require an rc5 at this point. > > thanks > -- PMM For sure most people don't use vtd ...
On Thu, 3 Dec 2020 at 10:59, Michael S. Tsirkin <mst@redhat.com> wrote: > > On Thu, Dec 03, 2020 at 10:20:03AM +0000, Peter Maydell wrote: > > On Wed, 2 Dec 2020 at 11:03, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > Patch 5 gave me pause but we do need patch 6 as > > > it's a guest triggerable assert, and it seemed > > > cleaner to just take the whole patchset than cherry-pick. > > > > Is this only "fixes a guest triggerable assert"? > > My understanding is that without the patches a rhel7 guest triggers > the assert if started with vtd enabled and virtio-net with > iommu_platform=on. > > https://bugs.launchpad.net/qemu/+bug/1885175 Bug reported in June ? Is this a regression since 5.1, or was it this way in 5.1 as well? thanks -- PMM
On Thu, 3 Dec 2020 at 11:02, Peter Maydell <peter.maydell@linaro.org> wrote: > > On Thu, 3 Dec 2020 at 10:59, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Thu, Dec 03, 2020 at 10:20:03AM +0000, Peter Maydell wrote: > > > On Wed, 2 Dec 2020 at 11:03, Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > Patch 5 gave me pause but we do need patch 6 as > > > > it's a guest triggerable assert, and it seemed > > > > cleaner to just take the whole patchset than cherry-pick. > > > > > > Is this only "fixes a guest triggerable assert"? > > > > My understanding is that without the patches a rhel7 guest triggers > > the assert if started with vtd enabled and virtio-net with > > iommu_platform=on. > > > > https://bugs.launchpad.net/qemu/+bug/1885175 > > Bug reported in June ? Is this a regression since 5.1, or > was it this way in 5.1 as well? MST confirmed on IRC that this isn't a regression since 5.1, so we'll fix it for 6.0. thanks -- PMM
Patch 5 gave me pause but we do need patch 6 as it's a guest triggerable assert, and it seemed cleaner to just take the whole patchset than cherry-pick. The following changes since commit d73c46e4a84e47ffc61b8bf7c378b1383e7316b5: Update version for v5.2.0-rc4 release (2020-12-01 16:21:01 +0000) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to a451089140c7b167661d0a23190e6d8bd7eae48d: memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type (2020-12-02 05:14:29 -0500) ---------------------------------------------------------------- pc,vhost: fixes A couple of last minute bugfixes. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> ---------------------------------------------------------------- Alex Chen (1): vhost-user-scsi: Fix memleaks in vus_proc_req() Eugenio Pérez (5): memory: Rename memory_region_notify_one to memory_region_notify_iommu_one memory: Add IOMMUTLBEvent memory: Add IOMMU_NOTIFIER_DEVIOTLB_UNMAP IOMMUTLBNotificationType intel_iommu: Skip page walking on device iotlb invalidations memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type include/exec/memory.h | 40 ++++++++------ contrib/vhost-user-scsi/vhost-user-scsi.c | 3 +- hw/arm/smmu-common.c | 13 +++-- hw/arm/smmuv3.c | 13 +++-- hw/i386/intel_iommu.c | 92 ++++++++++++++++++------------- hw/misc/tz-mpc.c | 32 ++++++----- hw/ppc/spapr_iommu.c | 15 ++--- hw/s390x/s390-pci-inst.c | 27 +++++---- hw/virtio/vhost.c | 2 +- hw/virtio/virtio-iommu.c | 30 +++++----- softmmu/memory.c | 29 ++++++---- 11 files changed, 167 insertions(+), 129 deletions(-)