From patchwork Mon Dec 14 15:57:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 11972429 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A40C4361B for ; Mon, 14 Dec 2020 16:10:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B7D3225A9 for ; Mon, 14 Dec 2020 16:10:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B7D3225A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koqQD-000708-C3 for qemu-devel@archiver.kernel.org; Mon, 14 Dec 2020 11:10:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koqEi-00084o-Km; Mon, 14 Dec 2020 10:58:08 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:60141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koqEZ-0001TV-O3; Mon, 14 Dec 2020 10:58:08 -0500 Received: from localhost.localdomain ([82.252.135.218]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MZTua-1ka79W1VGY-00WTIv; Mon, 14 Dec 2020 16:57:48 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 13/19] blockdev: Fix a memleak in drive_backup_prepare() Date: Mon, 14 Dec 2020 16:57:27 +0100 Message-Id: <20201214155733.207430-14-laurent@vivier.eu> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201214155733.207430-1-laurent@vivier.eu> References: <20201214155733.207430-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:735+zZjV7Kg4dys7SHq0LOXjYZoOFfqX/1cVH3mOYk/haK2LGKb Th8U6fcsWdlRLgXmtv1T60/d7Srcj+0kFXNA6R+1ST6eIWA+g0AVy4Y3128i+CeYAE70pjB 21wf6MP/ruvpsfcNzwy3TNtKiVIutCF7s2sZlMt8gjn/PexMhAbwSeM2DQeGBxRNZGUtsST lc3xAghxKEsu6Afh6tIFg== X-UI-Out-Filterresults: notjunk:1;V03:K0:ru3d2tFhvI8=:Q63Rp7jrB3UF+FXiXgUYVz yY/DkpNF7ifQYBE4UWU5rFn0KoVC/l9cxXCbidNFg8EoWmALQtjyLL4J0FXJ2Xj78XReeeOmX SEoErDpuE+jz0BAujXjjvMVITqrGxKXNlDykMvNzG+fc3j6IuCeT88UUjuae4wrmjHxgbuAZW gIevbxJXIXs1CZppw0V8Z94JY6XJkBXJfsoYXkBBP95USKBb7gv1skKdHMtUk2rDju5OT3vHW jOIVK2JZLs97KTRA6Kdu0k6+uJ+HxIri7Mza4uL0lWkcwY1wcnc0WlHumBUM00+9Br1BxwOWI GIzqy5LJ3IkYml/CttP7a2WQcvfaH+Tx2YGkd+dS2hS0qlvzvosXDh6gUhGjrPMODC7cEF3lC QVFwUK4Kyi30liDpVjcFaLcxbOu2GNATDW5N0EDXDg1yxu8WE3mUqUS8blJy19dUE7MOasupW KjShUm/gig== Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Li Qiang , qemu-trivial@nongnu.org, Michael Tokarev , Pan Nengyuan , Laurent Vivier , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Pan Nengyuan 'local_err' seems forgot to propagate in error path, it'll cause a memleak. Fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Kevin Wolf Reviewed-by: Li Qiang Signed-off-by: Chen Qun Message-Id: <20201023061218.2080844-7-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- blockdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockdev.c b/blockdev.c index 412354b4b6ac..2431448c5d41 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1827,6 +1827,7 @@ static void drive_backup_prepare(BlkActionState *common, Error **errp) if (set_backing_hd) { bdrv_set_backing_hd(target_bs, source, &local_err); if (local_err) { + error_propagate(errp, local_err); goto unref; } }