| Message ID | 20210109122631.167314-3-vsementsov@virtuozzo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rework iotests/check | expand |
On 1/9/21 6:26 AM, Vladimir Sementsov-Ogievskiy wrote: > If you run './check 303', check includes common.config which adjusts > $PATH to include '.' first, and therefore finds qcow2.py on PATH. But > if you run './303' directly, there is nothing to adjust PATH, and if > '.' is not already on your PATH by other means, the test fails because > the executable is not found. Adjust how we invoke the helper > executable to avoid needing a PATH search in the first place. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > tests/qemu-iotests/303 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303 > index 6c21774483..11cd9eeb26 100755 > --- a/tests/qemu-iotests/303 > +++ b/tests/qemu-iotests/303 > @@ -56,7 +56,7 @@ qemu_img_create('-f', iotests.imgfmt, disk, '10M') > > add_bitmap(1, 0, 6, False) > add_bitmap(2, 6, 8, True) > -dump = ['qcow2.py', disk, 'dump-header'] > +dump = ['./qcow2.py', disk, 'dump-header'] > subprocess.run(dump) > # Dump the metadata in JSON format > dump.append('-j') >
diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303 index 6c21774483..11cd9eeb26 100755 --- a/tests/qemu-iotests/303 +++ b/tests/qemu-iotests/303 @@ -56,7 +56,7 @@ qemu_img_create('-f', iotests.imgfmt, disk, '10M') add_bitmap(1, 0, 6, False) add_bitmap(2, 6, 8, True) -dump = ['qcow2.py', disk, 'dump-header'] +dump = ['./qcow2.py', disk, 'dump-header'] subprocess.run(dump) # Dump the metadata in JSON format dump.append('-j')
If you run './check 303', check includes common.config which adjusts $PATH to include '.' first, and therefore finds qcow2.py on PATH. But if you run './303' directly, there is nothing to adjust PATH, and if '.' is not already on your PATH by other means, the test fails because the executable is not found. Adjust how we invoke the helper executable to avoid needing a PATH search in the first place. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- tests/qemu-iotests/303 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)