| Message ID | 20210112044508.427338-12-david@gibson.dropbear.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Generalize memory encryption models | expand |
On Tue, 12 Jan 2021 15:45:06 +1100 David Gibson <david@gibson.dropbear.id.au> wrote: > We haven't yet implemented the fairly involved handshaking that will be > needed to migrate PEF protected guests. For now, just use a migration > blocker so we get a meaningful error if someone attempts this (this is the > same approach used by AMD SEV). > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > --- Reviewed-by: Greg Kurz <groug@kaod.org> > hw/ppc/pef.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c > index b227dc6905..822668d9ae 100644 > --- a/hw/ppc/pef.c > +++ b/hw/ppc/pef.c > @@ -38,6 +38,8 @@ struct PefGuestState { > }; > > #ifdef CONFIG_KVM > +static Error *pef_mig_blocker; > + > static int kvmppc_svm_init(Error **errp) > { > if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURE_GUEST)) { > @@ -54,6 +56,11 @@ static int kvmppc_svm_init(Error **errp) > } > } > > + /* add migration blocker */ > + error_setg(&pef_mig_blocker, "PEF: Migration is not implemented"); > + /* NB: This can fail if --only-migratable is used */ > + migrate_add_blocker(pef_mig_blocker, &error_fatal); > + > return 0; > } >
diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c index b227dc6905..822668d9ae 100644 --- a/hw/ppc/pef.c +++ b/hw/ppc/pef.c @@ -38,6 +38,8 @@ struct PefGuestState { }; #ifdef CONFIG_KVM +static Error *pef_mig_blocker; + static int kvmppc_svm_init(Error **errp) { if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURE_GUEST)) { @@ -54,6 +56,11 @@ static int kvmppc_svm_init(Error **errp) } } + /* add migration blocker */ + error_setg(&pef_mig_blocker, "PEF: Migration is not implemented"); + /* NB: This can fail if --only-migratable is used */ + migrate_add_blocker(pef_mig_blocker, &error_fatal); + return 0; }