From patchwork Tue Jan 12 09:39:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Chang X-Patchwork-Id: 12013157 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7DCEC433E0 for ; Tue, 12 Jan 2021 10:33:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5373F23103 for ; Tue, 12 Jan 2021 10:33:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5373F23103 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzGzQ-0004CB-Bs for qemu-devel@archiver.kernel.org; Tue, 12 Jan 2021 05:33:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzGDr-0007GA-Hq for qemu-devel@nongnu.org; Tue, 12 Jan 2021 04:44:19 -0500 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]:38991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzGDo-0008SV-Bp for qemu-devel@nongnu.org; Tue, 12 Jan 2021 04:44:19 -0500 Received: by mail-pf1-x433.google.com with SMTP id m6so1066845pfm.6 for ; Tue, 12 Jan 2021 01:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cxtPS90g1TNqtT+i/fhh8bp1iFvCkZkvTR85JBscTqQ=; b=ahGue6TE5wWFxzj833qG2W27jOnB0P21SFWBVn7tXbIZkqpVxW37Jbuxb5HQ1e96qz yK0qx9tg4zVPP/JafDV2EO+Mw44A1CUtCpeHMEQV7Oox30vuAWh0N/OhfuVgq9M1D6Le yfY4J63bJA7TZZQ1sTJp5Nuf2LoluX96B044ScCFzI8vbwCy5Q8UNCqybuSUTD9B3wJD fT+46qWxPfPFJyVFUd8hYwZ+VSCTqFbTt9TJ+PsCuSMTbTLMdnGsSetM23nUmPn8GB19 dJc+Ug0JKfMXHOZUazt4XxrVxUVj+Su3wJuIT1a8PHX3VqabRLi6+Nl1x1NN73AY3kYr VjWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cxtPS90g1TNqtT+i/fhh8bp1iFvCkZkvTR85JBscTqQ=; b=Zi3HoWODfZ9B6Taa/xP0MXX/Q4e4bTVJ8vVt5RkJGdtLt1wLVNeVPzwOIt4LnqF85H uW0DYYKZBk9kP9wH/mf0mt/Dx8x0CCOPosL/8yb3O+4rRfMTAyIMlF5Xam8boYe4bKHG OLfvWFHEkt8HqCoq7sA6SLr1TG0fr7QrWIhQCnZ9q4gpDdv6eCp08bFKL5yrMJe7H9jG D2HYezZrvNTjgi/qQm5Ani8OjqJ4da9tLnzGv9d1Kvx0yty+NoRAS9hPI533ObG1lJ00 yZPZ2ZX9aHwoZ24CHNIktNZqRpDf2OuIJTcW2PuxQB9RoF41jv7B3ig+HuvQNOBHcF4T LLYw== X-Gm-Message-State: AOAM532HyX+Yv3WFm8uyiMb3e30JWKyooIOxKIpRh/mrmfkygl/ddPjx URUhefgNmpN0xLhSayoLqWKcQxwTw7mlLSMA X-Google-Smtp-Source: ABdhPJxGJ/HsWhUe91vCvaJw/wwHd0pkIZc/ePrEgd3v6czv35fX8ClqO4k12VawUQWo8Uu71b4faw== X-Received: by 2002:aa7:8d12:0:b029:1ae:4344:3b4f with SMTP id j18-20020aa78d120000b02901ae43443b4fmr3772045pfe.16.1610444654236; Tue, 12 Jan 2021 01:44:14 -0800 (PST) Received: from frankchang-ThinkPad-T490.internal.sifive.com (114-34-229-221.HINET-IP.hinet.net. [114.34.229.221]) by smtp.gmail.com with ESMTPSA id h16sm2865664pgd.62.2021.01.12.01.44.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 01:44:13 -0800 (PST) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH v6 62/72] target/riscv: add "set round to odd" rounding mode helper function Date: Tue, 12 Jan 2021 17:39:36 +0800 Message-Id: <20210112093950.17530-63-frank.chang@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210112093950.17530-1-frank.chang@sifive.com> References: <20210112093950.17530-1-frank.chang@sifive.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=frank.chang@sifive.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Chang , Alistair Francis , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Frank Chang helper_set_rounding_mode() is responsible for SIGILL, and "round to odd" should be an interface private to translation, so add a new independent helper_set_rod_rounding_mode(). Signed-off-by: Frank Chang --- target/riscv/fpu_helper.c | 5 +++++ target/riscv/helper.h | 1 + target/riscv/internals.h | 1 + target/riscv/translate.c | 5 +++++ 4 files changed, 12 insertions(+) diff --git a/target/riscv/fpu_helper.c b/target/riscv/fpu_helper.c index ad84aeebc1c..ac3e7b4d08f 100644 --- a/target/riscv/fpu_helper.c +++ b/target/riscv/fpu_helper.c @@ -81,6 +81,11 @@ void helper_set_rounding_mode(CPURISCVState *env, uint32_t rm) set_float_rounding_mode(softrm, &env->fp_status); } +void helper_set_rod_rounding_mode(CPURISCVState *env) +{ + set_float_rounding_mode(float_round_to_odd, &env->fp_status); +} + static uint64_t do_fmadd_s(CPURISCVState *env, uint64_t rs1, uint64_t rs2, uint64_t rs3, int flags) { diff --git a/target/riscv/helper.h b/target/riscv/helper.h index e11cce3e8ea..1d52936c399 100644 --- a/target/riscv/helper.h +++ b/target/riscv/helper.h @@ -3,6 +3,7 @@ DEF_HELPER_2(raise_exception, noreturn, env, i32) /* Floating Point - rounding mode */ DEF_HELPER_FLAGS_2(set_rounding_mode, TCG_CALL_NO_WG, void, env, i32) +DEF_HELPER_FLAGS_1(set_rod_rounding_mode, TCG_CALL_NO_WG, void, env) /* Floating Point - fused */ DEF_HELPER_FLAGS_4(fmadd_s, TCG_CALL_NO_RWG, i64, env, i64, i64, i64) diff --git a/target/riscv/internals.h b/target/riscv/internals.h index 469cc418c4e..6a80c067706 100644 --- a/target/riscv/internals.h +++ b/target/riscv/internals.h @@ -43,6 +43,7 @@ enum { RISCV_FRM_RUP = 3, /* Round Up */ RISCV_FRM_RMM = 4, /* Round to Nearest, ties to Max Magnitude */ RISCV_FRM_DYN = 7, /* Dynamic rounding mode */ + RISCV_FRM_ROD = 8, /* Round to Odd */ }; static inline uint64_t nanbox_s(float32 f) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 511b7b868f5..2c9131271e0 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -30,6 +30,7 @@ #include "exec/log.h" #include "instmap.h" +#include "internals.h" /* global register indices */ static TCGv cpu_gpr[32], cpu_pc, cpu_vl; @@ -584,6 +585,10 @@ static void gen_set_rm(DisasContext *ctx, int rm) return; } ctx->frm = rm; + if (rm == RISCV_FRM_ROD) { + gen_helper_set_rod_rounding_mode(cpu_env); + return; + } t0 = tcg_const_i32(rm); gen_helper_set_rounding_mode(cpu_env, t0); tcg_temp_free_i32(t0);