| Message ID | 20210114165730.31607-11-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | testing/next (tags!, shippable/travis deprecation, regression fixes, checkpatch) | expand |
On 1/14/21 5:57 PM, Alex Bennée wrote: > From: Lukas Straub <lukasstraub2@web.de> > Again: Fixes: 50186051f42 ("Introduce yank feature") Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Lukas Straub <lukasstraub2@web.de> > [AJB: tweak MAINTAINERS] > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Message-Id: <20210114141918.5201cc9c@gecko.fritz.box> > --- > stubs/yank.c | 29 +++++++++++++++++++++++++++++ > MAINTAINERS | 1 + > stubs/meson.build | 1 + > 3 files changed, 31 insertions(+) > create mode 100644 stubs/yank.c > > diff --git a/stubs/yank.c b/stubs/yank.c > new file mode 100644 > index 0000000000..6090416065 > --- /dev/null > +++ b/stubs/yank.c > @@ -0,0 +1,29 @@ > +#include "qemu/osdep.h" > +#include "qemu/yank.h" > + > +bool yank_register_instance(const YankInstance *instance, Error **errp) > +{ > + return true; > +} > + > +void yank_unregister_instance(const YankInstance *instance) > +{ > +} > + > +void yank_register_function(const YankInstance *instance, > + YankFn *func, > + void *opaque) > +{ > +} > + > +void yank_unregister_function(const YankInstance *instance, > + YankFn *func, > + void *opaque) > +{ > +} > + > +void yank_generic_iochannel(void *opaque) > +{ > +} > + > + > diff --git a/MAINTAINERS b/MAINTAINERS > index cb0656aec3..07e4851aa4 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2736,6 +2736,7 @@ Yank feature > M: Lukas Straub <lukasstraub2@web.de> > S: Odd fixes > F: util/yank.c > +F: stubs/yank.c > F: include/qemu/yank.h > F: qapi/yank.json > > diff --git a/stubs/meson.build b/stubs/meson.build > index 80b1d81a31..1a656cd070 100644 > --- a/stubs/meson.build > +++ b/stubs/meson.build > @@ -47,6 +47,7 @@ stub_ss.add(files('vm-stop.c')) > stub_ss.add(files('win32-kbd-hook.c')) > stub_ss.add(files('cpu-synchronize-state.c')) > if have_block > + stub_ss.add(files('yank.c')) > stub_ss.add(files('replay-tools.c')) > endif > if have_system >
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > On 1/14/21 5:57 PM, Alex Bennée wrote: >> From: Lukas Straub <lukasstraub2@web.de> >> > > Again: > > Fixes: 50186051f42 ("Introduce yank feature") > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Hmm I need to improve my tooling to pick up the Fixes and add a TODO. > >> Signed-off-by: Lukas Straub <lukasstraub2@web.de> >> [AJB: tweak MAINTAINERS] >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> Message-Id: <20210114141918.5201cc9c@gecko.fritz.box> >> --- >> stubs/yank.c | 29 +++++++++++++++++++++++++++++ >> MAINTAINERS | 1 + >> stubs/meson.build | 1 + >> 3 files changed, 31 insertions(+) >> create mode 100644 stubs/yank.c >> >> diff --git a/stubs/yank.c b/stubs/yank.c >> new file mode 100644 >> index 0000000000..6090416065 >> --- /dev/null >> +++ b/stubs/yank.c >> @@ -0,0 +1,29 @@ >> +#include "qemu/osdep.h" >> +#include "qemu/yank.h" >> + >> +bool yank_register_instance(const YankInstance *instance, Error **errp) >> +{ >> + return true; >> +} >> + >> +void yank_unregister_instance(const YankInstance *instance) >> +{ >> +} >> + >> +void yank_register_function(const YankInstance *instance, >> + YankFn *func, >> + void *opaque) >> +{ >> +} >> + >> +void yank_unregister_function(const YankInstance *instance, >> + YankFn *func, >> + void *opaque) >> +{ >> +} >> + >> +void yank_generic_iochannel(void *opaque) >> +{ >> +} >> + >> + >> diff --git a/MAINTAINERS b/MAINTAINERS >> index cb0656aec3..07e4851aa4 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -2736,6 +2736,7 @@ Yank feature >> M: Lukas Straub <lukasstraub2@web.de> >> S: Odd fixes >> F: util/yank.c >> +F: stubs/yank.c >> F: include/qemu/yank.h >> F: qapi/yank.json >> >> diff --git a/stubs/meson.build b/stubs/meson.build >> index 80b1d81a31..1a656cd070 100644 >> --- a/stubs/meson.build >> +++ b/stubs/meson.build >> @@ -47,6 +47,7 @@ stub_ss.add(files('vm-stop.c')) >> stub_ss.add(files('win32-kbd-hook.c')) >> stub_ss.add(files('cpu-synchronize-state.c')) >> if have_block >> + stub_ss.add(files('yank.c')) >> stub_ss.add(files('replay-tools.c')) >> endif >> if have_system >>
diff --git a/stubs/yank.c b/stubs/yank.c new file mode 100644 index 0000000000..6090416065 --- /dev/null +++ b/stubs/yank.c @@ -0,0 +1,29 @@ +#include "qemu/osdep.h" +#include "qemu/yank.h" + +bool yank_register_instance(const YankInstance *instance, Error **errp) +{ + return true; +} + +void yank_unregister_instance(const YankInstance *instance) +{ +} + +void yank_register_function(const YankInstance *instance, + YankFn *func, + void *opaque) +{ +} + +void yank_unregister_function(const YankInstance *instance, + YankFn *func, + void *opaque) +{ +} + +void yank_generic_iochannel(void *opaque) +{ +} + + diff --git a/MAINTAINERS b/MAINTAINERS index cb0656aec3..07e4851aa4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2736,6 +2736,7 @@ Yank feature M: Lukas Straub <lukasstraub2@web.de> S: Odd fixes F: util/yank.c +F: stubs/yank.c F: include/qemu/yank.h F: qapi/yank.json diff --git a/stubs/meson.build b/stubs/meson.build index 80b1d81a31..1a656cd070 100644 --- a/stubs/meson.build +++ b/stubs/meson.build @@ -47,6 +47,7 @@ stub_ss.add(files('vm-stop.c')) stub_ss.add(files('win32-kbd-hook.c')) stub_ss.add(files('cpu-synchronize-state.c')) if have_block + stub_ss.add(files('yank.c')) stub_ss.add(files('replay-tools.c')) endif if have_system