[PULL,06/30] sdlaudio: fill remaining sample buffer with silence

Commit Message

Gerd Hoffmann Jan. 15, 2021, 1:21 p.m. UTC

From: Volker Rümelin <[e-mail]>

Fill the remaining sample buffer with silence. To fill it with
zeroes is wrong for unsigned samples because this is silence
with a DC bias.

Signed-off-by: Volker Rümelin <[e-mail]>
Reviewed-by: Thomas Huth <[e-mail]>
Message-id: [e-mail]
Message-Id: <[e-mail]>
Signed-off-by: Gerd Hoffmann <[e-mail]>
---
 audio/sdlaudio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c
index 79eed23849ea..01ae4c600e80 100644
--- a/audio/sdlaudio.c
+++ b/audio/sdlaudio.c
@@ -235,7 +235,8 @@  static void sdl_callback (void *opaque, Uint8 *buf, int len)
 
     /* clear remaining buffer that we couldn't fill with data */
     if (len) {
-        memset(buf, 0, len);
+        audio_pcm_info_clear_buf(&hw->info, buf,
+                                 len / hw->info.bytes_per_frame);
     }
 }