[v6,04/14] blockdev: fix drive_backup_prepare() missed error

Commit Message

Vladimir Sementsov-Ogievskiy Jan. 16, 2021, 9:51 p.m. UTC

We leak local_err and don't report failure to the caller. It's
definitely wrong, let's fix.

Signed-off-by: Vladimir Sementsov-Ogievskiy <[e-mail]>
Reviewed-by: Greg Kurz <[e-mail]>
Reviewed-by: Alberto Garcia <[e-mail]>
---
 blockdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch

diff --git a/blockdev.c b/blockdev.c
index 84c5cde07c..753fb90c16 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1825,9 +1825,7 @@  static void drive_backup_prepare(BlkActionState *common, Error **errp)
     aio_context_acquire(aio_context);
 
     if (set_backing_hd) {
-        bdrv_set_backing_hd(target_bs, source, &local_err);
-        if (local_err) {
-            error_propagate(errp, local_err);
+        if (bdrv_set_backing_hd(target_bs, source, errp) < 0) {
             goto unref;
         }
     }