| Message ID | 20210117192446.23753-11-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw: Mark the device with no migratable fields | expand |
* Philippe Mathieu-Daudé (f4bug@amsat.org) wrote: > This device doesn't have fields to migrate. Be explicit > by using vmstate_qdev_no_state_to_migrate. > > Add a more descriptive comment to keep a clear separation > between static property vs runtime changeable. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> OK, Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> although I think it's quite interesting; I think we have a base class which has data to migrate which expects any child classes to migrate it's data; so marking it as not actually having any state is not quite right. > --- > hw/usb/hcd-ohci.h | 2 ++ > hw/usb/hcd-ohci.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/hw/usb/hcd-ohci.h b/hw/usb/hcd-ohci.h > index 11ac57058d1..fd4842a352f 100644 > --- a/hw/usb/hcd-ohci.h > +++ b/hw/usb/hcd-ohci.h > @@ -101,6 +101,8 @@ struct OHCISysBusState { > /*< public >*/ > > OHCIState ohci; > + > + /* Properties */ > char *masterbus; > uint32_t num_ports; > uint32_t firstport; > diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c > index f8c64c8b95b..302aab30992 100644 > --- a/hw/usb/hcd-ohci.c > +++ b/hw/usb/hcd-ohci.c > @@ -2007,6 +2007,7 @@ static void ohci_sysbus_class_init(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > > dc->realize = ohci_realize_pxa; > + dc->vmsd = vmstate_qdev_no_state_to_migrate; > set_bit(DEVICE_CATEGORY_USB, dc->categories); > dc->desc = "OHCI USB Controller"; > device_class_set_props(dc, ohci_sysbus_properties); > -- > 2.26.2 >
diff --git a/hw/usb/hcd-ohci.h b/hw/usb/hcd-ohci.h index 11ac57058d1..fd4842a352f 100644 --- a/hw/usb/hcd-ohci.h +++ b/hw/usb/hcd-ohci.h @@ -101,6 +101,8 @@ struct OHCISysBusState { /*< public >*/ OHCIState ohci; + + /* Properties */ char *masterbus; uint32_t num_ports; uint32_t firstport; diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index f8c64c8b95b..302aab30992 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2007,6 +2007,7 @@ static void ohci_sysbus_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); dc->realize = ohci_realize_pxa; + dc->vmsd = vmstate_qdev_no_state_to_migrate; set_bit(DEVICE_CATEGORY_USB, dc->categories); dc->desc = "OHCI USB Controller"; device_class_set_props(dc, ohci_sysbus_properties);
This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Add a more descriptive comment to keep a clear separation between static property vs runtime changeable. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/usb/hcd-ohci.h | 2 ++ hw/usb/hcd-ohci.c | 1 + 2 files changed, 3 insertions(+)