| Message ID | 20210118170308.282442-2-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error | expand |
On 1/18/21 11:03 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > include/scsi/utils.h | 2 ++ > scsi/utils.c | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/include/scsi/utils.h b/include/scsi/utils.h > index fbc55882799..096489c6cd1 100644 > --- a/include/scsi/utils.h > +++ b/include/scsi/utils.h > @@ -57,6 +57,8 @@ extern const struct SCSISense sense_code_LBA_OUT_OF_RANGE; > extern const struct SCSISense sense_code_INVALID_FIELD; > /* Illegal request, Invalid field in parameter list */ > extern const struct SCSISense sense_code_INVALID_PARAM; > +/* Illegal request, Invalid value in parameter list */ > +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE; > /* Illegal request, Parameter list length error */ > extern const struct SCSISense sense_code_INVALID_PARAM_LEN; > /* Illegal request, LUN not supported */ Pre-existing: the term 'illegal' is suspect in computer science (the code isn't breaking any laws); I prefer 'invalid'. But that's a pet peeve of mine, and not something you need to change here. > diff --git a/scsi/utils.c b/scsi/utils.c > index b37c2830148..793c3a6b9c9 100644 > --- a/scsi/utils.c > +++ b/scsi/utils.c > @@ -197,6 +197,11 @@ const struct SCSISense sense_code_INVALID_PARAM = { > .key = ILLEGAL_REQUEST, .asc = 0x26, .ascq = 0x00 > }; > > +/* Illegal request, Invalid value in parameter list */ > +const struct SCSISense sense_code_INVALID_PARAM_VALUE = { > + .key = ILLEGAL_REQUEST, .asc = 0x26, .ascq = 0x01 > +}; > + > /* Illegal request, Parameter list length error */ > const struct SCSISense sense_code_INVALID_PARAM_LEN = { > .key = ILLEGAL_REQUEST, .asc = 0x1a, .ascq = 0x00 > Reviewed-by: Eric Blake <eblake@redhat.com>
Hi, > > +/* Illegal request, Invalid value in parameter list */ > > +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE; > Pre-existing: the term 'illegal' is suspect in computer science (the > code isn't breaking any laws); Indeed. It's named that way in the scsi specs though, and being consistent with that is a reasonable thing too ... take care, Gerd
On 1/20/21 5:01 PM, Gerd Hoffmann wrote: > Hi, > >>> +/* Illegal request, Invalid value in parameter list */ >>> +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE; > >> Pre-existing: the term 'illegal' is suspect in computer science (the >> code isn't breaking any laws); > > Indeed. It's named that way in the scsi specs though, and being > consistent with that is a reasonable thing too ... In v2 I renamed 'illegal' in the description comments but not in the #definitions (which match the specs). Regards, Phil.
diff --git a/include/scsi/utils.h b/include/scsi/utils.h index fbc55882799..096489c6cd1 100644 --- a/include/scsi/utils.h +++ b/include/scsi/utils.h @@ -57,6 +57,8 @@ extern const struct SCSISense sense_code_LBA_OUT_OF_RANGE; extern const struct SCSISense sense_code_INVALID_FIELD; /* Illegal request, Invalid field in parameter list */ extern const struct SCSISense sense_code_INVALID_PARAM; +/* Illegal request, Invalid value in parameter list */ +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE; /* Illegal request, Parameter list length error */ extern const struct SCSISense sense_code_INVALID_PARAM_LEN; /* Illegal request, LUN not supported */ diff --git a/scsi/utils.c b/scsi/utils.c index b37c2830148..793c3a6b9c9 100644 --- a/scsi/utils.c +++ b/scsi/utils.c @@ -197,6 +197,11 @@ const struct SCSISense sense_code_INVALID_PARAM = { .key = ILLEGAL_REQUEST, .asc = 0x26, .ascq = 0x00 }; +/* Illegal request, Invalid value in parameter list */ +const struct SCSISense sense_code_INVALID_PARAM_VALUE = { + .key = ILLEGAL_REQUEST, .asc = 0x26, .ascq = 0x01 +}; + /* Illegal request, Parameter list length error */ const struct SCSISense sense_code_INVALID_PARAM_LEN = { .key = ILLEGAL_REQUEST, .asc = 0x1a, .ascq = 0x00
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- include/scsi/utils.h | 2 ++ scsi/utils.c | 5 +++++ 2 files changed, 7 insertions(+)