diff mbox series

[v2,1/2] tests/docker: Install static libc package in CentOS 7

Message ID 20210121172829.1643620-2-f4bug@amsat.org (mailing list archive)
State New, archived
Headers show
Series gitlab-ci: Test linux-user on CentOS 7 | expand

Commit Message

Philippe Mathieu-Daudé Jan. 21, 2021, 5:28 p.m. UTC
We need to install the static libc package to be able to run
the TCG tests:

  $ make check-tcg
  ...
    BUILD   TCG tests for x86_64-softmmu
    BUILD   x86_64-softmmu guest-tests with cc
  /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
  /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
    BUILD   TCG tests for x86_64-linux-user
    BUILD   x86_64-linux-user guest-tests with cc
  /usr/bin/ld: cannot find -lpthread
  /usr/bin/ld: cannot find -lc
  collect2: error: ld returned 1 exit status
  make[2]: *** [threadcount] Error 1
  make[1]: *** [cross-build-guest-tests] Error 2
  make: *** [build-tcg-tests-x86_64-linux-user] Error 2

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/docker/dockerfiles/centos7.docker | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Huth Jan. 21, 2021, 6:25 p.m. UTC | #1
On 21/01/2021 18.28, Philippe Mathieu-Daudé wrote:
> We need to install the static libc package to be able to run
> the TCG tests:
> 
>    $ make check-tcg
>    ...
>      BUILD   TCG tests for x86_64-softmmu
>      BUILD   x86_64-softmmu guest-tests with cc
>    /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
>    /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
>      BUILD   TCG tests for x86_64-linux-user
>      BUILD   x86_64-linux-user guest-tests with cc
>    /usr/bin/ld: cannot find -lpthread
>    /usr/bin/ld: cannot find -lc
>    collect2: error: ld returned 1 exit status
>    make[2]: *** [threadcount] Error 1
>    make[1]: *** [cross-build-guest-tests] Error 2
>    make: *** [build-tcg-tests-x86_64-linux-user] Error 2
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/docker/dockerfiles/centos7.docker | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker
> index 6f11af1989e..75fdb53c7c0 100644
> --- a/tests/docker/dockerfiles/centos7.docker
> +++ b/tests/docker/dockerfiles/centos7.docker
> @@ -15,6 +15,7 @@ ENV PACKAGES \
>       gettext \
>       git \
>       glib2-devel \
> +    glibc-static \
>       gnutls-devel \
>       libaio-devel \
>       libepoxy-devel \

Reviewed-by: Thomas Huth <thuth@redhat.com>
Wainer dos Santos Moschetta Jan. 21, 2021, 6:30 p.m. UTC | #2
On 1/21/21 2:28 PM, Philippe Mathieu-Daudé wrote:
> We need to install the static libc package to be able to run
> the TCG tests:
>
>    $ make check-tcg
>    ...
>      BUILD   TCG tests for x86_64-softmmu
>      BUILD   x86_64-softmmu guest-tests with cc
>    /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
>    /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
>      BUILD   TCG tests for x86_64-linux-user
>      BUILD   x86_64-linux-user guest-tests with cc
>    /usr/bin/ld: cannot find -lpthread
>    /usr/bin/ld: cannot find -lc
>    collect2: error: ld returned 1 exit status
>    make[2]: *** [threadcount] Error 1
>    make[1]: *** [cross-build-guest-tests] Error 2
>    make: *** [build-tcg-tests-x86_64-linux-user] Error 2
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/docker/dockerfiles/centos7.docker | 1 +
>   1 file changed, 1 insertion(+)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker
> index 6f11af1989e..75fdb53c7c0 100644
> --- a/tests/docker/dockerfiles/centos7.docker
> +++ b/tests/docker/dockerfiles/centos7.docker
> @@ -15,6 +15,7 @@ ENV PACKAGES \
>       gettext \
>       git \
>       glib2-devel \
> +    glibc-static \
>       gnutls-devel \
>       libaio-devel \
>       libepoxy-devel \
diff mbox series

Patch

diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/centos7.docker
index 6f11af1989e..75fdb53c7c0 100644
--- a/tests/docker/dockerfiles/centos7.docker
+++ b/tests/docker/dockerfiles/centos7.docker
@@ -15,6 +15,7 @@  ENV PACKAGES \
     gettext \
     git \
     glib2-devel \
+    glibc-static \
     gnutls-devel \
     libaio-devel \
     libepoxy-devel \