| Message ID | 20210122105836.1878506-5-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | meson: Try to clarify TCG / TCI options for new users | expand |
On 22/01/2021 11.58, Philippe Mathieu-Daudé wrote: > Users might want to enable all features, without realizing some > features have negative effect. Rename '--enable-tcg-interpreter' > as '--disable-native-tcg' to avoid user selecting this feature > without understanding it. '--enable-tcg-interpreter' is kept in > for backward compability with scripts. > > Suggested-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > RFC so it can be discarded from the series > > configure | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 71bdc523aa0..5e56fa76499 100755 > --- a/configure > +++ b/configure > @@ -1121,7 +1121,8 @@ for opt do > ;; > --disable-tcg-interpreter) tcg_interpreter="no" > ;; > - --enable-tcg-interpreter) tcg_interpreter="yes" > + --enable-tcg-interpreter) # backward compatibility > + --disable-native-tcg) tcg_interpreter="yes" > ;; > --disable-cap-ng) cap_ng="disabled" > ;; > @@ -1753,7 +1754,7 @@ Advanced options (experts only): > --with-trace-file=NAME Full PATH,NAME of file to store traces > Default:trace-<pid> > --disable-slirp disable SLIRP userspace network connectivity > - --enable-tcg-interpreter enable TCG with bytecode interpreter (experimental and slow) > + --disable-native-tcg enable TCG with bytecode interpreter (experimental and slow) The more I think about it, the more I like the idea. Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/configure b/configure index 71bdc523aa0..5e56fa76499 100755 --- a/configure +++ b/configure @@ -1121,7 +1121,8 @@ for opt do ;; --disable-tcg-interpreter) tcg_interpreter="no" ;; - --enable-tcg-interpreter) tcg_interpreter="yes" + --enable-tcg-interpreter) # backward compatibility + --disable-native-tcg) tcg_interpreter="yes" ;; --disable-cap-ng) cap_ng="disabled" ;; @@ -1753,7 +1754,7 @@ Advanced options (experts only): --with-trace-file=NAME Full PATH,NAME of file to store traces Default:trace-<pid> --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (experimental and slow) + --disable-native-tcg enable TCG with bytecode interpreter (experimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimization --oss-lib path to OSS library --cpu=CPU Build for host CPU [$cpu]
Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter' is kept in for backward compability with scripts. Suggested-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- RFC so it can be discarded from the series configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)