| Message ID | 20210127195753.59773-1-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 27 Jan 2021 at 19:58, Kevin Wolf <kwolf@redhat.com> wrote: > > The following changes since commit bf159f0bdc7b8e7aa8342dedb3829ca744c1b612: > > Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2021-01-27.for-upstream' into staging (2021-01-27 17:40:25 +0000) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to a44be0334beae3a9affb4a3a92cc6852993d7a84: > > iotests: rename and move 169 and 199 tests (2021-01-27 20:53:14 +0100) > > ---------------------------------------------------------------- > Block layer patches: > > - Fix crash on write to read-only devices > - iotests: Rewrite 'check' in Python, get rid of 'groups' and allow > non-numeric test case names Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM
On Wed, 27 Jan 2021 at 19:58, Kevin Wolf <kwolf@redhat.com> wrote: > > The following changes since commit bf159f0bdc7b8e7aa8342dedb3829ca744c1b612: > > Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2021-01-27.for-upstream' into staging (2021-01-27 17:40:25 +0000) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to a44be0334beae3a9affb4a3a92cc6852993d7a84: > > iotests: rename and move 169 and 199 tests (2021-01-27 20:53:14 +0100) > > ---------------------------------------------------------------- > Block layer patches: > > - Fix crash on write to read-only devices > - iotests: Rewrite 'check' in Python, get rid of 'groups' and allow > non-numeric test case names > > ---------------------------------------------------------------- I somehow failed to notice before applying this, but this breaks 'make check' on the netbsd and freebsd VMs. As usual the build log is pretty opaque, but this looks like the probable culprit: env: python3: No such file or directory gmake: *** [/home/qemu/qemu-test.nU2bcG/src/tests/Makefile.include:144: check-block] Error 1 The python in the netbsd VM is /usr/pkg/bin/python3.7. Something seems to be ignoring the --python= passed into our configure and assuming that "python3" is always a valid executable. thanks -- PMM
28.01.2021 21:19, Peter Maydell wrote: > On Wed, 27 Jan 2021 at 19:58, Kevin Wolf <kwolf@redhat.com> wrote: >> >> The following changes since commit bf159f0bdc7b8e7aa8342dedb3829ca744c1b612: >> >> Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2021-01-27.for-upstream' into staging (2021-01-27 17:40:25 +0000) >> >> are available in the Git repository at: >> >> git://repo.or.cz/qemu/kevin.git tags/for-upstream >> >> for you to fetch changes up to a44be0334beae3a9affb4a3a92cc6852993d7a84: >> >> iotests: rename and move 169 and 199 tests (2021-01-27 20:53:14 +0100) >> >> ---------------------------------------------------------------- >> Block layer patches: >> >> - Fix crash on write to read-only devices >> - iotests: Rewrite 'check' in Python, get rid of 'groups' and allow >> non-numeric test case names >> >> ---------------------------------------------------------------- > > I somehow failed to notice before applying this, but this > breaks 'make check' on the netbsd and freebsd VMs. > > As usual the build log is pretty opaque, but this looks like the > probable culprit: > > env: python3: No such file or directory > gmake: *** [/home/qemu/qemu-test.nU2bcG/src/tests/Makefile.include:144: > check-block] Error 1 > > The python in the netbsd VM is /usr/pkg/bin/python3.7. Something > seems to be ignoring the --python= passed into our configure > and assuming that "python3" is always a valid executable. > Seems, that's shows that the fact that "PYTHON" variable in check-block.sh works for me doesn't mean that it works everywhere.. My fault, I look closer tomorrow.
The following changes since commit bf159f0bdc7b8e7aa8342dedb3829ca744c1b612: Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2021-01-27.for-upstream' into staging (2021-01-27 17:40:25 +0000) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to a44be0334beae3a9affb4a3a92cc6852993d7a84: iotests: rename and move 169 and 199 tests (2021-01-27 20:53:14 +0100) ---------------------------------------------------------------- Block layer patches: - Fix crash on write to read-only devices - iotests: Rewrite 'check' in Python, get rid of 'groups' and allow non-numeric test case names ---------------------------------------------------------------- Kevin Wolf (2): block: Separate blk_is_writable() and blk_supports_write_perm() virtio-scsi-test: Test writing to scsi-cd device Vladimir Sementsov-Ogievskiy (6): iotests: 146: drop extra whitespaces from .out file iotests: add findtests.py iotests: add testenv.py iotests: add testrunner.py iotests: rewrite check into python iotests: rename and move 169 and 199 tests docs/devel/testing.rst | 50 +- include/sysemu/block-backend.h | 3 +- block/block-backend.c | 19 +- hw/block/dataplane/xen-block.c | 2 +- hw/block/fdc.c | 9 +- hw/block/m25p80.c | 6 +- hw/block/nand.c | 2 +- hw/block/nvme-ns.c | 7 +- hw/block/onenand.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- hw/block/swim.c | 6 +- hw/block/virtio-blk.c | 6 +- hw/block/xen-block.c | 2 +- hw/ide/core.c | 2 +- hw/misc/sifive_u_otp.c | 2 +- hw/ppc/pnv_pnor.c | 2 +- hw/scsi/scsi-disk.c | 10 +- hw/scsi/scsi-generic.c | 4 +- hw/sd/sd.c | 6 +- hw/usb/dev-storage.c | 4 +- tests/qtest/virtio-scsi-test.c | 39 + tests/qemu-iotests/findtests.py | 159 +++ tests/qemu-iotests/iotests.py | 8 + tests/qemu-iotests/testenv.py | 281 +++++ tests/qemu-iotests/testrunner.py | 367 +++++++ Makefile | 1 - tests/check-block.sh | 3 +- tests/qemu-iotests/146.out | 780 +++++++------- tests/qemu-iotests/check | 1095 +++----------------- tests/qemu-iotests/common.env.in | 3 - tests/qemu-iotests/group | 323 ------ tests/qemu-iotests/meson.build | 3 - .../{199 => tests/migrate-bitmaps-postcopy-test} | 0 .../migrate-bitmaps-postcopy-test.out} | 0 .../{169 => tests/migrate-bitmaps-test} | 0 .../{169.out => tests/migrate-bitmaps-test.out} | 0 37 files changed, 1481 insertions(+), 1729 deletions(-) create mode 100644 tests/qemu-iotests/findtests.py create mode 100644 tests/qemu-iotests/testenv.py create mode 100644 tests/qemu-iotests/testrunner.py delete mode 100644 tests/qemu-iotests/common.env.in delete mode 100644 tests/qemu-iotests/group rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%) rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%) rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%) rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)