diff mbox series

tcg/tci: Implement INDEX_op_ld8s_i64

Message ID 20210127210737.2050633-1-sw@weilnetz.de (mailing list archive)
State New, archived
Headers show
Series tcg/tci: Implement INDEX_op_ld8s_i64 | expand

Commit Message

Stefan Weil Jan. 27, 2021, 9:07 p.m. UTC
That TCG opcode is used by debian-buster (arm64) running ffmpeg:

    qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm

Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 tcg/tci.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Richard Henderson Jan. 27, 2021, 10:55 p.m. UTC | #1
On 1/27/21 11:07 AM, Stefan Weil wrote:
>          case INDEX_op_ld8s_i64:
> -            TODO();
> +            t0 = *tb_ptr++;
> +            t1 = tci_read_r(regs, &tb_ptr);
> +            t2 = tci_read_s32(&tb_ptr);
> +            tci_write_reg8(regs, t0, *(int8_t *)(t1 + t2));
>              break;

This doesn't work, because tci_write_reg8 truncates to uint8_t again.  You need
to use tci_write_reg().


r~
diff mbox series

Patch

diff --git a/tcg/tci.c b/tcg/tci.c
index ddbb259e1d..3d5e50b4df 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -886,7 +886,10 @@  uintptr_t QEMU_DISABLE_CFI tcg_qemu_tb_exec(CPUArchState *env,
             tci_write_reg8(regs, t0, *(uint8_t *)(t1 + t2));
             break;
         case INDEX_op_ld8s_i64:
-            TODO();
+            t0 = *tb_ptr++;
+            t1 = tci_read_r(regs, &tb_ptr);
+            t2 = tci_read_s32(&tb_ptr);
+            tci_write_reg8(regs, t0, *(int8_t *)(t1 + t2));
             break;
         case INDEX_op_ld16u_i64:
             t0 = *tb_ptr++;