| Message ID | 20210128144125.3696119-8-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/mips: Replace integer by MMUAccessType enum when possible | expand |
在 2021/1/28 下午10:41, Philippe Mathieu-Daudé 写道: > The single caller, mips_cpu_tlb_fill(), passes MMUAccessType > to page_table_walk_refill(). Let the prototype use it as > argument, as it is stricter than an integer. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > target/mips/tlb_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/mips/tlb_helper.c b/target/mips/tlb_helper.c > index 9216c7a91b3..afcc269750d 100644 > --- a/target/mips/tlb_helper.c > +++ b/target/mips/tlb_helper.c > @@ -621,8 +621,8 @@ static int walk_directory(CPUMIPSState *env, uint64_t *vaddr, > } > } > > -static bool page_table_walk_refill(CPUMIPSState *env, vaddr address, int rw, > - int mmu_idx) > +static bool page_table_walk_refill(CPUMIPSState *env, vaddr address, > + MMUAccessType access_type, int mmu_idx) > { > int gdw = (env->CP0_PWSize >> CP0PS_GDW) & 0x3F; > int udw = (env->CP0_PWSize >> CP0PS_UDW) & 0x3F;
On 1/28/21 4:41 AM, Philippe Mathieu-Daudé wrote: > -static bool page_table_walk_refill(CPUMIPSState *env, vaddr address, int rw, > - int mmu_idx) > +static bool page_table_walk_refill(CPUMIPSState *env, vaddr address, > + MMUAccessType access_type, int mmu_idx) The parameter name has changed without any other change to the function. If this compiles, it surely means that the parameter is unused. r~
diff --git a/target/mips/tlb_helper.c b/target/mips/tlb_helper.c index 9216c7a91b3..afcc269750d 100644 --- a/target/mips/tlb_helper.c +++ b/target/mips/tlb_helper.c @@ -621,8 +621,8 @@ static int walk_directory(CPUMIPSState *env, uint64_t *vaddr, } } -static bool page_table_walk_refill(CPUMIPSState *env, vaddr address, int rw, - int mmu_idx) +static bool page_table_walk_refill(CPUMIPSState *env, vaddr address, + MMUAccessType access_type, int mmu_idx) { int gdw = (env->CP0_PWSize >> CP0PS_GDW) & 0x3F; int udw = (env->CP0_PWSize >> CP0PS_UDW) & 0x3F;
The single caller, mips_cpu_tlb_fill(), passes MMUAccessType to page_table_walk_refill(). Let the prototype use it as argument, as it is stricter than an integer. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- target/mips/tlb_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)