| Message ID | 20210201211456.1133364-2-wainersm@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allow to build virtiofsd without the entire tools | expand |
> Subject: [PATCH 1/1] virtiofsd: Allow to build it without the tools > > This changed the Meson build script to allow virtiofsd be built even > though the tools build is disabled, thus honoring the --enable-virtiofsd > option. > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> I misunderstood that virtiofsd builds somehow depends on tools build at that time. Thanks for fixing. I did quick build test. Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
On 2/2/21 2:55 AM, misono.tomohiro@fujitsu.com wrote: >> Subject: [PATCH 1/1] virtiofsd: Allow to build it without the tools >> >> This changed the Meson build script to allow virtiofsd be built even >> though the tools build is disabled, thus honoring the --enable-virtiofsd >> option. >> >> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > I misunderstood that virtiofsd builds somehow depends on tools build at that time. > Thanks for fixing. I did quick build test. Thanks for the review and test! If not needed a v2 for this patch, please could the maintainer add to the commit message: Fixes: cece116c939d219070b250338439c2d16f94e3da (configure: add option for virtiofsd) - Wainer > > Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> >
* Wainer dos Santos Moschetta (wainersm@redhat.com) wrote: > > On 2/2/21 2:55 AM, misono.tomohiro@fujitsu.com wrote: > > > Subject: [PATCH 1/1] virtiofsd: Allow to build it without the tools > > > > > > This changed the Meson build script to allow virtiofsd be built even > > > though the tools build is disabled, thus honoring the --enable-virtiofsd > > > option. > > > > > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > I misunderstood that virtiofsd builds somehow depends on tools build at that time. > > Thanks for fixing. I did quick build test. > Thanks for the review and test! > > If not needed a v2 for this patch, please could the maintainer add to the > commit message: > > Fixes: cece116c939d219070b250338439c2d16f94e3da (configure: add option for > virtiofsd) OK, I cna add that; I'll take it through virtiofs next time I need to do a pull. > - Wainer > > > > > Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> > >
On Mon, Feb 01, 2021 at 06:14:56PM -0300, Wainer dos Santos Moschetta wrote: > This changed the Meson build script to allow virtiofsd be built even > though the tools build is disabled, thus honoring the --enable-virtiofsd > option. > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > --- > tools/meson.build | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
* Wainer dos Santos Moschetta (wainersm@redhat.com) wrote: > > On 2/2/21 2:55 AM, misono.tomohiro@fujitsu.com wrote: > > > Subject: [PATCH 1/1] virtiofsd: Allow to build it without the tools > > > > > > This changed the Meson build script to allow virtiofsd be built even > > > though the tools build is disabled, thus honoring the --enable-virtiofsd > > > option. > > > > > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > I misunderstood that virtiofsd builds somehow depends on tools build at that time. > > Thanks for fixing. I did quick build test. > Thanks for the review and test! > > If not needed a v2 for this patch, please could the maintainer add to the > commit message: > > Fixes: cece116c939d219070b250338439c2d16f94e3da (configure: add option for > virtiofsd) Queued with that line added to the commit message > - Wainer > > > > > Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> > > > >
diff --git a/tools/meson.build b/tools/meson.build index fdce66857d..3e5a0abfa2 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -10,8 +10,11 @@ if get_option('virtiofsd').enabled() error('virtiofsd requires Linux') elif not seccomp.found() or not libcap_ng.found() error('virtiofsd requires libcap-ng-devel and seccomp-devel') - elif not have_tools or 'CONFIG_VHOST_USER' not in config_host - error('virtiofsd needs tools and vhost-user support') + elif 'CONFIG_VHOST_USER' not in config_host + error('virtiofsd needs vhost-user support') + else + # Disabled all the tools but virtiofsd. + have_virtiofsd = true endif endif elif get_option('virtiofsd').disabled() or not have_system
This changed the Meson build script to allow virtiofsd be built even though the tools build is disabled, thus honoring the --enable-virtiofsd option. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> --- tools/meson.build | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)