diff mbox series

[PULL,v2,08/10] block/nvme: Properly display doorbell stride length in trace event

Message ID 20210202162834.269789-9-kwolf@redhat.com (mailing list archive)
State New, archived
Headers show
Series [PULL,v2,01/10] MAINTAINERS: Add Vladimir as co-maintainer for Block Jobs | expand

Commit Message

Kevin Wolf Feb. 2, 2021, 4:28 p.m. UTC
From: Philippe Mathieu-Daudé <philmd@redhat.com>

Commit 15b2260bef3 ("block/nvme: Trace controller capabilities")
misunderstood the doorbell stride value from the datasheet, use
the correct one. The 'doorbell_scale' variable used few lines
later is correct.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210127212137.3482291-2-philmd@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
 block/nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/block/nvme.c b/block/nvme.c
index 5a6fbacf4a..80c4318d8f 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -745,7 +745,7 @@  static int nvme_init(BlockDriverState *bs, const char *device, int namespace,
     trace_nvme_controller_capability("Contiguous Queues Required",
     trace_nvme_controller_capability("Doorbell Stride",
-                                     2 << (2 + NVME_CAP_DSTRD(cap)));
+                                     1 << (2 + NVME_CAP_DSTRD(cap)));
     trace_nvme_controller_capability("Subsystem Reset Supported",
     trace_nvme_controller_capability("Memory Page Size Minimum",