From patchwork Thu Feb 11 12:27:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 12083151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0028C433DB for ; Thu, 11 Feb 2021 12:37:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B25C64DD8 for ; Thu, 11 Feb 2021 12:37:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B25C64DD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lABDz-0005dp-VS for qemu-devel@archiver.kernel.org; Thu, 11 Feb 2021 07:37:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lABBl-0003Yi-0A for qemu-devel@nongnu.org; Thu, 11 Feb 2021 07:35:17 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:45409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lABBe-0006qi-Ig for qemu-devel@nongnu.org; Thu, 11 Feb 2021 07:35:16 -0500 Received: by mail-wr1-x42a.google.com with SMTP id m13so3967785wro.12 for ; Thu, 11 Feb 2021 04:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JuFQ5vAHnDaon6m/CuHXMWN0xMbchoTGcLjdHzV+MRs=; b=dcN4mQRnZIohtn5TIUsFsFOWwxvktSNhkuFNhCsqHeEEhXkhWlJtOyWK0JbwqHvmRs CrP4RIpEpXqHWbYNcPnc7qnSlaB+E0G2Xqn57YA8asTZD/yfZNFrsiUXdKEl20I5kbZl DpoXeIR0qYfPvLAF18oMVKuwxYyOmyUl/pw/HJ5TCtO19ueGoEq3d58z7iLkZEZr8YXK weQuHZ4lcluI2z/ien6FX1eWZU5zh2NP3ZDaJ+71VypSC8bBL4YexjHoycwVSn5E7tWt PgUTdA7DsKnXl/sAeXyJlyraTuVW6Ju2/+XgzJGoAzmkqMExThFWul0SjgDMYaHFhpk6 C+YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JuFQ5vAHnDaon6m/CuHXMWN0xMbchoTGcLjdHzV+MRs=; b=NjXZnx9Qi/2PmqVpdycFgduvhlAg/qrEG/uPT1e3AFWB/J7pvrJgetYJ/dVxIEzxrh BPl3FF6JQDwXrNzOmfcVBxXNtjL6fnLaaNioWIMJRyRCowwAoF+Kg8bFHey+bR27jR0k SsJvsn8/MvKPtLgsJB2t+3DT7e4mRipBcF5aaRblRcDYtOEFoQV9JTLchx9sf0R8fGvZ w+CpnROEJ+EU+s7ZnFqvwjPs7LSq6jfJ7g6gNzGPk/BdM87IjLpckRznKyky3BaUQJn0 pISKaqCYyfTvnG1xx7pRpbvn5Cl+kMfdV6nG/oseSV+kRTdJkSHhVBh5gyQgR4SSVqAf AMyg== X-Gm-Message-State: AOAM530PwRggBv58uvsXo4dpHZH+2R3BWrOH/Zg+IXbmLMo/8Tyf6Dff 31fV8hH8clSR3QKr4zaiErAKOQ== X-Google-Smtp-Source: ABdhPJzR1NXlSMzyyxx7RsYfBO00Bm1WVlqe3agfL/phF/TO7JRd3eAN+A4sfWYg2wcxkxKFYNzMbQ== X-Received: by 2002:adf:f6c3:: with SMTP id y3mr4295304wrp.24.1613046909204; Thu, 11 Feb 2021 04:35:09 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p10sm642597wrt.69.2021.02.11.04.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Feb 2021 04:35:07 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 31FB51FF9B; Thu, 11 Feb 2021 12:27:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 12/15] target/ppc: Drop use of gdb_get_float64() and ldfq_p() Date: Thu, 11 Feb 2021 12:27:47 +0000 Message-Id: <20210211122750.22645-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210211122750.22645-1-alex.bennee@linaro.org> References: <20210211122750.22645-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, Peter Maydell , berrange@redhat.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , richard.henderson@linaro.org, f4bug@amsat.org, Greg Kurz , =?utf-8?q?Alex_Benn=C3=A9e?= , cota@braap.org, "open list:PowerPC TCG CPUs" , aurelien@aurel32.net, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell We used to make a distinction between 'float64'/'float32' types and the 'uint64_t'/'uint32_t' types, requiring special conversion operations to go between them. We've now dropped this distinction as unnecessary, and the 'float*' types remain primarily for documentation purposes when used in places like the function prototypes of TCG helper functions. This means that there's no need for a special gdb_get_float64() function to write a float64 value to the GDB protocol buffer; we can just use gdb_get_reg64(). Similarly, for reading a value out of the GDB buffer into a float64 we can use ldq_p() and need not use ldfq_p(). Signed-off-by: Peter Maydell Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20210208113428.7181-4-peter.maydell@linaro.org> --- target/ppc/gdbstub.c | 8 ++++---- target/ppc/translate_init.c.inc | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index 01459dd31d..c28319fb97 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -130,7 +130,7 @@ int ppc_cpu_gdb_read_register(CPUState *cs, GByteArray *buf, int n) gdb_get_regl(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); } else { switch (n) { case 64: @@ -184,7 +184,7 @@ int ppc_cpu_gdb_read_register_apple(CPUState *cs, GByteArray *buf, int n) gdb_get_reg64(buf, env->gpr[n]); } else if (n < 64) { /* fprs */ - gdb_get_float64(buf, *cpu_fpr_ptr(env, n - 32)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n - 32)); } else if (n < 96) { /* Altivec */ gdb_get_reg64(buf, n - 64); @@ -241,7 +241,7 @@ int ppc_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) env->gpr[n] = ldtul_p(mem_buf); } else if (n < 64) { /* fprs */ - *cpu_fpr_ptr(env, n - 32) = ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n - 32) = ldq_p(mem_buf); } else { switch (n) { case 64: @@ -291,7 +291,7 @@ int ppc_cpu_gdb_write_register_apple(CPUState *cs, uint8_t *mem_buf, int n) env->gpr[n] = ldq_p(mem_buf); } else if (n < 64) { /* fprs */ - *cpu_fpr_ptr(env, n - 32) = ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n - 32) = ldq_p(mem_buf); } else { switch (n) { case 64 + 32: diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.inc index 3ec45cbc19..e7324e85cd 100644 --- a/target/ppc/translate_init.c.inc +++ b/target/ppc/translate_init.c.inc @@ -9923,7 +9923,7 @@ static int gdb_get_float_reg(CPUPPCState *env, GByteArray *buf, int n) { uint8_t *mem_buf; if (n < 32) { - gdb_get_float64(buf, *cpu_fpr_ptr(env, n)); + gdb_get_reg64(buf, *cpu_fpr_ptr(env, n)); mem_buf = gdb_get_reg_ptr(buf, 8); ppc_maybe_bswap_register(env, mem_buf, 8); return 8; @@ -9941,7 +9941,7 @@ static int gdb_set_float_reg(CPUPPCState *env, uint8_t *mem_buf, int n) { if (n < 32) { ppc_maybe_bswap_register(env, mem_buf, 8); - *cpu_fpr_ptr(env, n) = ldfq_p(mem_buf); + *cpu_fpr_ptr(env, n) = ldq_p(mem_buf); return 8; } if (n == 32) {