| Message ID | 20210221004717.426903-1-alxndr@bu.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fuzz: fix the pro100 generic-fuzzer config | expand |
On 2/21/21 1:47 AM, Alexander Bulekov wrote: > The device-type names for the pro100 network cards, are i8255.. We were > matching "eepro", which catches the PCI PIO/MMIO regions for those > devices, however misses the actual PCI device, which we use to map the > BARs, before fuzzing. Fix that > > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> > --- > tests/qtest/fuzz/generic_fuzz_configs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h > index 5d599765c4..2454c627ff 100644 > --- a/tests/qtest/fuzz/generic_fuzz_configs.h > +++ b/tests/qtest/fuzz/generic_fuzz_configs.h > @@ -177,7 +177,7 @@ const generic_fuzz_config predefined_configs[] = { > .name = "i82550", > .args = "-machine q35 -nodefaults " > "-device i82550,netdev=net0 -netdev user,id=net0", > - .objects = "eepro*" > + .objects = "i8255*" What about i82562 & i82801? Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On 210221 0947, Philippe Mathieu-Daudé wrote: > On 2/21/21 1:47 AM, Alexander Bulekov wrote: > > The device-type names for the pro100 network cards, are i8255.. We were > > matching "eepro", which catches the PCI PIO/MMIO regions for those > > devices, however misses the actual PCI device, which we use to map the > > BARs, before fuzzing. Fix that > > > > Signed-off-by: Alexander Bulekov <alxndr@bu.edu> > > --- > > tests/qtest/fuzz/generic_fuzz_configs.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h > > index 5d599765c4..2454c627ff 100644 > > --- a/tests/qtest/fuzz/generic_fuzz_configs.h > > +++ b/tests/qtest/fuzz/generic_fuzz_configs.h > > @@ -177,7 +177,7 @@ const generic_fuzz_config predefined_configs[] = { > > .name = "i82550", > > .args = "-machine q35 -nodefaults " > > "-device i82550,netdev=net0 -netdev user,id=net0", > > - .objects = "eepro*" > > + .objects = "i8255*" > > What about i82562 & i82801? True. If we start fuzzing those, we will need to adjust the config. > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Thanks
diff --git a/tests/qtest/fuzz/generic_fuzz_configs.h b/tests/qtest/fuzz/generic_fuzz_configs.h index 5d599765c4..2454c627ff 100644 --- a/tests/qtest/fuzz/generic_fuzz_configs.h +++ b/tests/qtest/fuzz/generic_fuzz_configs.h @@ -177,7 +177,7 @@ const generic_fuzz_config predefined_configs[] = { .name = "i82550", .args = "-machine q35 -nodefaults " "-device i82550,netdev=net0 -netdev user,id=net0", - .objects = "eepro*" + .objects = "i8255*" },{ .name = "sdhci-v3", .args = "-nodefaults -device sdhci-pci,sd-spec-version=3 "
The device-type names for the pro100 network cards, are i8255.. We were matching "eepro", which catches the PCI PIO/MMIO regions for those devices, however misses the actual PCI device, which we use to map the BARs, before fuzzing. Fix that Signed-off-by: Alexander Bulekov <alxndr@bu.edu> --- tests/qtest/fuzz/generic_fuzz_configs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)