diff mbox series

block: Change write_threshold to uint64 in BlockDeviceInfo

Message ID 20210302020608.13563-1-wang.yi59@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series block: Change write_threshold to uint64 in BlockDeviceInfo | expand

Commit Message

Yi Wang March 2, 2021, 2:06 a.m. UTC 
From: renlei4 <ren.lei4@zte.com.cn>

write_threshold is saved as uint64, but BlockDeviceInfo use int to describe it.

normally it works well if threshold less than max int:
 # virsh domblkthreshold v6_163 sda 9223372036854775807
 # virsh qemu-monitor-command v6_163  '{ "execute": "query-named-block-nodes" }' |grep threshold
            "write_threshold": 9223372036854775807,

overflow happened if threshold greater than max int:
 # virsh domblkthreshold v6_163 sda 9223372036854775811
 # virsh qemu-monitor-command v6_163   '{ "execute": "query-named-block-nodes" }' |grep threshold
            "write_threshold": -9223372036854775805,

Fixes: e2462113b200 "block: add event when disk usage exceeds threshold"

Signed-off-by: Ren Lei <ren.lei4@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
 qapi/block-core.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 9f555d5..00b8729 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -409,7 +409,7 @@ 
             '*bps_wr_max_length': 'int', '*iops_max_length': 'int',
             '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',
             '*iops_size': 'int', '*group': 'str', 'cache': 'BlockdevCacheInfo',
-            'write_threshold': 'int', '*dirty-bitmaps': ['BlockDirtyInfo'] } }
+            'write_threshold': 'uint64', '*dirty-bitmaps': ['BlockDirtyInfo'] } }
 
 ##
 # @BlockDeviceIoStatus: