diff mbox series

[PULL,15/20] spapr.c: add 'unplug already in progress' message for PHB unplug

Message ID 20210310041002.333813-16-david@gibson.dropbear.id.au (mailing list archive)
State New, archived
Headers show
Series [PULL,01/20] hw/display/sm501: Remove dead code for non-32-bit RGB surfaces | expand

Commit Message

David Gibson March 10, 2021, 4:09 a.m. UTC 
From: Daniel Henrique Barboza <danielhb413@gmail.com>

Both CPU hotunplug and PC_DIMM unplug reports an user warning,
mentioning that the hotunplug is in progress, if consecutive
'device_del' are issued in quick succession.

Do the same for PHBs in spapr_phb_unplug_request().

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20210226163301.419727-4-danielhb413@gmail.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/spapr.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 6eaddb12cb..aca3ef9d58 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -4034,6 +4034,10 @@  static void spapr_phb_unplug_request(HotplugHandler *hotplug_dev,
     if (!spapr_drc_unplug_requested(drc)) {
         spapr_drc_unplug_request(drc);
         spapr_hotplug_req_remove_by_index(drc);
+    } else {
+        error_setg(errp,
+                   "PCI Host Bridge unplug already in progress for device %s",
+                   dev->id);
     }
 }