include/ui/console.h: Delete is_surface_bgr()

Commit Message

Peter Maydell March 14, 2021, 4:39 p.m. UTC

The function is_surface_bgr() is no longer used anywhere,
so we can delete it.

Signed-off-by: Peter Maydell <[e-mail]>
---
 include/ui/console.h | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Philippe Mathieu-Daudé March 14, 2021, 9:59 p.m. UTC | #1

On 3/14/21 5:39 PM, Peter Maydell wrote:
> The function is_surface_bgr() is no longer used anywhere,
> so we can delete it.
> 
> Signed-off-by: Peter Maydell <[e-mail]>
> ---
>  include/ui/console.h | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>

Gerd Hoffmann March 17, 2021, 9:58 a.m. UTC | #2

On Sun, Mar 14, 2021 at 04:39:27PM +0000, Peter Maydell wrote:
> The function is_surface_bgr() is no longer used anywhere,
> so we can delete it.

Added to (6.1) ui queue.

thanks,
  Gerd

Patch

diff --git a/include/ui/console.h b/include/ui/console.h
index c960b7066cc..810ce7988c0 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -267,16 +267,6 @@  PixelFormat qemu_default_pixelformat(int bpp);
 DisplaySurface *qemu_create_displaysurface(int width, int height);
 void qemu_free_displaysurface(DisplaySurface *surface);
 
-static inline int is_surface_bgr(DisplaySurface *surface)
-{
-    if (PIXMAN_FORMAT_BPP(surface->format) == 32 &&
-        PIXMAN_FORMAT_TYPE(surface->format) == PIXMAN_TYPE_ABGR) {
-        return 1;
-    } else {
-        return 0;
-    }
-}
-
 static inline int is_buffer_shared(DisplaySurface *surface)
 {
     return !(surface->flags & QEMU_ALLOCATED_FLAG);