[PULL,0/3] Audio 20210316 patches

Pull-request

git://git.kraxel.org/qemu tags/audio-20210316-pull-request

Message

Gerd Hoffmann March 16, 2021, 10:47 a.m. UTC

The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:

  Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-reque=
st' into staging (2021-03-15 19:23:00 +0000)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/audio-20210316-pull-request

for you to fetch changes up to 3ba6e3f6888d2825709eba2f623f0615069c036c:

  coreaudio: Handle output device change (2021-03-16 07:17:50 +0100)

----------------------------------------------------------------
coreaudio fixes and cleanups.

----------------------------------------------------------------

Akihiko Odaki (3):
  coreaudio: Drop support for macOS older than 10.6
  coreaudio: Extract device operations
  coreaudio: Handle output device change

 audio/coreaudio.c | 428 +++++++++++++++++++++++++---------------------
 1 file changed, 235 insertions(+), 193 deletions(-)

--=20
2.30.2

Comments

[e-mail] March 16, 2021, 10:54 a.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: [e-mail]
Subject: [PULL 0/3] Audio 20210316 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
54c97ba coreaudio: Handle output device change
3013a57 coreaudio: Extract device operations
45d1cb4 coreaudio: Drop support for macOS older than 10.6

=== OUTPUT BEGIN ===
1/3 Checking commit 45d1cb4bb7c7 (coreaudio: Drop support for macOS older than 10.6)
2/3 Checking commit 3013a5778d0a (coreaudio: Extract device operations)
ERROR: space prohibited between function name and open parenthesis '('
#76: FILE: audio/coreaudio.c:383:
+        coreaudio_playback_logerr (status,

ERROR: space prohibited between function name and open parenthesis '('
#83: FILE: audio/coreaudio.c:388:
+        dolog ("Could not initialize playback - Unknown Audiodevice\n");

ERROR: space prohibited between function name and open parenthesis '('
#94: FILE: audio/coreaudio.c:396:
+        coreaudio_playback_logerr (status,

ERROR: space prohibited between function name and open parenthesis '('
#122: FILE: audio/coreaudio.c:415:
+        coreaudio_playback_logerr (status,

ERROR: line over 90 characters
#123: FILE: audio/coreaudio.c:416:
+                                    "Could not set device buffer frame size %" PRIu32 "\n",

WARNING: line over 80 characters
#124: FILE: audio/coreaudio.c:417:
+                                    (uint32_t)core->audioDevicePropertyBufferFrameSize);

ERROR: space prohibited between function name and open parenthesis '('
#135: FILE: audio/coreaudio.c:425:
+        coreaudio_playback_logerr (status,

WARNING: line over 80 characters
#141: FILE: audio/coreaudio.c:429:
+    core->hw.samples = core->bufferCount * core->audioDevicePropertyBufferFrameSize;

ERROR: space prohibited between function name and open parenthesis '('
#149: FILE: audio/coreaudio.c:435:
+        coreaudio_playback_logerr (status,

ERROR: space prohibited between function name and open parenthesis '('
#164: FILE: audio/coreaudio.c:445:
+        coreaudio_playback_logerr (status,

WARNING: line over 80 characters
#166: FILE: audio/coreaudio.c:447:
+                                   core->outputStreamBasicDescription.mSampleRate);

ERROR: space prohibited between function name and open parenthesis '('
#181: FILE: audio/coreaudio.c:459:
+        coreaudio_playback_logerr (status, "Could not set IOProc\n");

ERROR: space prohibited between function name and open parenthesis '('
#218: FILE: audio/coreaudio.c:501:
+        dolog("Could not create mutex\nReason: %s\n", strerror (err));

ERROR: space prohibited between function name and open parenthesis '('
#225: FILE: audio/coreaudio.c:508:
+    audio_pcm_init_info (&hw->info, as);

ERROR: space prohibited between function name and open parenthesis '('
#240: FILE: audio/coreaudio.c:523:
+static void coreaudio_fini_out (HWVoiceOut *hw)

total: 12 errors, 3 warnings, 224 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 54c97bac0510 (coreaudio: Handle output device change)
ERROR: space prohibited between function name and open parenthesis '('
#74: FILE: audio/coreaudio.c:335:
+        coreaudio_unlock (core, "audioDeviceIOProc(old device)");

ERROR: line over 90 characters
#160: FILE: audio/coreaudio.c:495:
+            if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {

WARNING: line over 80 characters
#170: FILE: audio/coreaudio.c:504:
+    if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {

ERROR: line over 90 characters
#195: FILE: audio/coreaudio.c:529:
+            if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {

ERROR: space prohibited between function name and open parenthesis '('
#196: FILE: audio/coreaudio.c:530:
+                coreaudio_logerr (status, "Could not resume playback\n");

ERROR: line over 90 characters
#204: FILE: audio/coreaudio.c:538:
+            if (status != kAudioHardwareBadDeviceError && status != kAudioHardwareNoError) {

ERROR: space prohibited between function name and open parenthesis '('
#233: FILE: audio/coreaudio.c:567:
+    coreaudio_unlock (core, __func__);

ERROR: space prohibited between function name and open parenthesis '('
#263: FILE: audio/coreaudio.c:607:
+        coreaudio_playback_logerr (status,

ERROR: space prohibited between function name and open parenthesis '('
#291: FILE: audio/coreaudio.c:635:
+        dolog("Could not destroy mutex\nReason: %s\n", strerror (err));

WARNING: line over 80 characters
#312: FILE: audio/coreaudio.c:657:
+        coreaudio_logerr(status, "Could not remove voice property change listener\n");

total: 8 errors, 2 warnings, 321 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

Peter Maydell March 17, 2021, 6:27 p.m. UTC | #2

On Tue, 16 Mar 2021 at 10:50, Gerd Hoffmann <[e-mail]> wrote:
>
> The following changes since commit 2615a5e433aeb812c300d3a48e1a88e1303e2339:
>
>   Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-reque=
> st' into staging (2021-03-15 19:23:00 +0000)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/audio-20210316-pull-request
>
> for you to fetch changes up to 3ba6e3f6888d2825709eba2f623f0615069c036c:
>
>   coreaudio: Handle output device change (2021-03-16 07:17:50 +0100)
>
> ----------------------------------------------------------------
> coreaudio fixes and cleanups.
>
> ----------------------------------------------------------------
>
> Akihiko Odaki (3):
>   coreaudio: Drop support for macOS older than 10.6
>   coreaudio: Extract device operations
>   coreaudio: Handle output device change
>
>  audio/coreaudio.c | 428 +++++++++++++++++++++++++---------------------
>  1 file changed, 235 insertions(+), 193 deletions(-)


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM