| Message ID | 20210317032217.1460684-1-michael.roth@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20210317032217.1460684-1-michael.roth@amd.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210317032217.1460684-1-michael.roth@amd.com
Subject: [PULL for-6.0 0/6] qemu-ga patch queue for soft-freeze
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210304123951.163411-1-joel@jms.id.au -> patchew/20210304123951.163411-1-joel@jms.id.au
* [new tag] patchew/20210317032217.1460684-1-michael.roth@amd.com -> patchew/20210317032217.1460684-1-michael.roth@amd.com
Switched to a new branch 'test'
737a2b0 qga: return a more explicit error on why a command is disabled
0bf8864 qga: Switch and case should be at the same indent
59f1523 qga: Open brace '{' following struct go on the same
9a65ca2 qga: Delete redundant spaces
f45a2c1 qga: Add spaces around operator
0a0eab1 qga: Correct loop count in qmp_guest_get_vcpus()
=== OUTPUT BEGIN ===
1/6 Checking commit 0a0eab1610f6 (qga: Correct loop count in qmp_guest_get_vcpus())
2/6 Checking commit f45a2c1f5bc7 (qga: Add spaces around operator)
3/6 Checking commit 9a65ca2783f0 (qga: Delete redundant spaces)
ERROR: spaces required around that '*' (ctx:WxV)
#34: FILE: qga/commands-win32.c:2177:
+ typedef NTSTATUS(WINAPI *rtl_get_version_t)(
^
total: 1 errors, 0 warnings, 16 lines checked
Patch 3/6 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/6 Checking commit 59f152349ac0 (qga: Open brace '{' following struct go on the same)
5/6 Checking commit 0bf88641ae37 (qga: Switch and case should be at the same indent)
6/6 Checking commit 737a2b0e78d0 (qga: return a more explicit error on why a command is disabled)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210317032217.1460684-1-michael.roth@amd.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Wed, 17 Mar 2021 at 03:22, Michael Roth <michael.roth@amd.com> wrote: > > The following changes since commit 5b7f5586d182b0cafb1f8d558992a14763e2953e: > > Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210315-pull-request' into staging (2021-03-16 13:17:54 +0000) > > are available in the Git repository at: > > git@github.com:mdroth/qemu.git tags/qga-pull-2021-03-16-tag > > for you to fetch changes up to c98939daeca3beb21c85560acede8d3529e363d9: > > qga: return a more explicit error on why a command is disabled (2021-03-16 20:21:47 -0500) > > ---------------------------------------------------------------- > qemu-ga patch queue for soft-freeze > > * fix guest-get-vcpus reporting after vcpu unplug > * coding style fix-ups > * report a reason for disabled commands > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM
The following changes since commit 5b7f5586d182b0cafb1f8d558992a14763e2953e: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210315-pull-request' into staging (2021-03-16 13:17:54 +0000) are available in the Git repository at: git@github.com:mdroth/qemu.git tags/qga-pull-2021-03-16-tag for you to fetch changes up to c98939daeca3beb21c85560acede8d3529e363d9: qga: return a more explicit error on why a command is disabled (2021-03-16 20:21:47 -0500) ---------------------------------------------------------------- qemu-ga patch queue for soft-freeze * fix guest-get-vcpus reporting after vcpu unplug * coding style fix-ups * report a reason for disabled commands ---------------------------------------------------------------- AlexChen (4): qga: Add spaces around operator qga: Delete redundant spaces qga: Open brace '{' following struct go on the same qga: Switch and case should be at the same indent Lin Ma (1): qga: Correct loop count in qmp_guest_get_vcpus() Marc-André Lureau (1): qga: return a more explicit error on why a command is disabled include/qapi/qmp/dispatch.h | 4 ++- qapi/qmp-dispatch.c | 6 +++-- qapi/qmp-registry.c | 10 ++++--- qga/channel-win32.c | 7 ++--- qga/commands-posix.c | 47 ++++++++++++--------------------- qga/commands-win32.c | 26 +++++++++---------- qga/commands.c | 4 +-- qga/main.c | 63 ++++++++++++++++++++++----------------------- 8 files changed, 79 insertions(+), 88 deletions(-)