From patchwork Thu Mar 18 03:05:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Chen X-Patchwork-Id: 12147235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE31C433E0 for ; Thu, 18 Mar 2021 03:14:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2142764E98 for ; Thu, 18 Mar 2021 03:14:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2142764E98 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMj6o-0000a7-0o for qemu-devel@archiver.kernel.org; Wed, 17 Mar 2021 23:14:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMj3p-0004S7-By for qemu-devel@nongnu.org; Wed, 17 Mar 2021 23:10:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:54700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMj3n-0005sv-51 for qemu-devel@nongnu.org; Wed, 17 Mar 2021 23:10:57 -0400 IronPort-SDR: 3AvUBeMgRQIBfC+yDTA9pjocnYwyW05qs8ibBzA8j5PAq51rINxNIOB1G7NC03DzvOiJAvisn9 EXuUcPvMWPIw== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="189681359" X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="189681359" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 20:10:54 -0700 IronPort-SDR: 00vr1ULMk0fTAh7QFOV5zeBlig4BtTwwfAWaKxvTK84OBdy5VzdpVbx/lLCyt7fD2+kFcVjsUC UdzklnsLHKsw== X-IronPort-AV: E=Sophos;i="5.81,257,1610438400"; d="scan'208";a="412898313" Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 20:10:51 -0700 From: Zhang Chen To: Jason Wang , qemu-dev , Eric Blake , "Dr. David Alan Gilbert" , Markus Armbruster , Lukas Straub Subject: [PATCH V3 7/7] net/net.c: Add handler for COLO passthrough connection Date: Thu, 18 Mar 2021 11:05:00 +0800 Message-Id: <20210318030500.55352-8-chen.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210318030500.55352-1-chen.zhang@intel.com> References: <20210318030500.55352-1-chen.zhang@intel.com> MIME-Version: 1.0 Received-SPF: pass client-ip=134.134.136.24; envelope-from=chen.zhang@intel.com; helo=mga09.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Zhang Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Use connection protocol,src port,dst port,src ip,dst ip as the key to bypass certain network traffic in COLO compare. Signed-off-by: Zhang Chen --- net/net.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 153 insertions(+) diff --git a/net/net.c b/net/net.c index 037dcc5973..84065ec74e 100644 --- a/net/net.c +++ b/net/net.c @@ -55,6 +55,8 @@ #include "sysemu/sysemu.h" #include "net/filter.h" #include "qapi/string-output-visitor.h" +#include "net/colo-compare.h" +#include "qom/object_interfaces.h" /* Net bridge is currently not supported for W32. */ #if !defined(_WIN32) @@ -1151,14 +1153,165 @@ void qmp_netdev_del(const char *id, Error **errp) qemu_del_net_client(nc); } +static CompareState *colo_passthrough_check(L4_Connection *conn, Error **errp) +{ + Object *container; + Object *obj; + CompareState *s; + + if (!conn->id) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "id", + "Need input colo-compare object id"); + return NULL; + } + + container = object_get_objects_root(); + obj = object_resolve_path_component(container, conn->id); + if (!obj) { + error_setg(errp, "colo-compare '%s' not found", conn->id); + return NULL; + } + + s = COLO_COMPARE(obj); + + if (conn->protocol == -1) { + error_setg(errp, "COLO pass through get wrong protocol"); + return NULL; + } + + if ((conn->src_ip && !qemu_isdigit(conn->src_ip[0])) || + (conn->dst_ip && !qemu_isdigit(conn->dst_ip[0]))) { + error_setg(errp, "COLO pass through get wrong IP"); + return NULL; + } + + if (conn->src_port > 65536 || conn->src_port < 0 || + conn->dst_port > 65536 || conn->dst_port < 0) { + error_setg(errp, "COLO pass through get wrong port"); + return NULL; + } + + return s; +} + +static void compare_passthrough_add(CompareState *s, + L4_Connection *conn, + Error **errp) +{ + PassthroughEntry *bypass = NULL, *next = NULL, *origin = NULL; + + bypass = g_new0(PassthroughEntry, 1); + + bypass->l4_protocol = conn->protocol; + bypass->src_port = conn->src_port; + bypass->dst_port = conn->dst_port; + + if (!inet_aton(conn->src_ip, &bypass->src_ip)) { + bypass->src_ip.s_addr = 0; + } + + if (!inet_aton(conn->dst_ip, &bypass->dst_ip)) { + bypass->dst_ip.s_addr = 0; + } + + qemu_mutex_lock(&s->passthroughlist_mutex); + if (!QLIST_EMPTY(&s->passthroughlist)) { + QLIST_FOREACH_SAFE(origin, &s->passthroughlist, node, next) { + if ((bypass->l4_protocol == origin->l4_protocol) && + (bypass->src_port == origin->src_port) && + (bypass->src_ip.s_addr == origin->src_ip.s_addr) && + (bypass->dst_ip.s_addr == origin->dst_ip.s_addr)) { + error_setg(errp, "The pass through connection already exists"); + g_free(bypass); + qemu_mutex_unlock(&s->passthroughlist_mutex); + return; + } + } + } + + QLIST_INSERT_HEAD(&s->passthroughlist, bypass, node); + qemu_mutex_unlock(&s->passthroughlist_mutex); +} + +static void compare_passthrough_del(CompareState *s, + L4_Connection *conn, + Error **errp) +{ + PassthroughEntry *bypass = NULL, *next = NULL, *origin = NULL; + + bypass = g_new0(PassthroughEntry, 1); + + bypass->l4_protocol = conn->protocol; + bypass->src_port = conn->src_port; + bypass->dst_port = conn->dst_port; + + if (!inet_aton(conn->src_ip, &bypass->src_ip)) { + bypass->src_ip.s_addr = 0; + } + + if (!inet_aton(conn->dst_ip, &bypass->dst_ip)) { + bypass->dst_ip.s_addr = 0; + } + + qemu_mutex_lock(&s->passthroughlist_mutex); + if (!QLIST_EMPTY(&s->passthroughlist)) { + QLIST_FOREACH_SAFE(origin, &s->passthroughlist, node, next) { + if ((bypass->l4_protocol == origin->l4_protocol) && + (bypass->src_port == origin->src_port) && + (bypass->src_ip.s_addr == origin->src_ip.s_addr) && + (bypass->dst_ip.s_addr == origin->dst_ip.s_addr)) { + QLIST_REMOVE(origin, node); + g_free(origin); + g_free(bypass); + qemu_mutex_unlock(&s->passthroughlist_mutex); + return; + } + } + error_setg(errp, "The pass through list can't find the connection"); + } else { + error_setg(errp, "The pass through connection list is empty"); + } + + g_free(bypass); + qemu_mutex_unlock(&s->passthroughlist_mutex); +} + void qmp_colo_passthrough_add(L4_Connection *conn, Error **errp) { /* Setup passthrough connection */ + CompareState *s; + Error *err = NULL; + + s = colo_passthrough_check(conn, &err); + if (err) { + error_propagate(errp, err); + return; + } + + compare_passthrough_add(s, conn, &err); + if (err) { + error_propagate(errp, err); + return; + } } void qmp_colo_passthrough_del(L4_Connection *conn, Error **errp) { /* Delete passthrough connection */ + CompareState *s; + Error *err = NULL; + + s = colo_passthrough_check(conn, &err); + if (err) { + error_propagate(errp, err); + return; + } + + compare_passthrough_del(s, conn, &err); + if (err) { + error_propagate(errp, err); + return; + } } static void netfilter_print_info(Monitor *mon, NetFilterState *nf)