mbox

[PULL,v2,00/11] emulated nvme updates and fixes

Message ID 20210318115757.58923-1-its@irrelevant.dk (mailing list archive)
State New, archived
Headers show

Pull-request

git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request

Message

Klaus Jensen March 18, 2021, 11:57 a.m. UTC
From: Klaus Jensen <k.jensen@samsung.com>

Hi Peter,

The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76:

  Merge remote-tracking branch 'remotes/vivier/tags/q800-for-6.0-pull-request' into staging (2021-03-18 10:05:37 +0000)

are available in the Git repository at:

  git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request

for you to fetch changes up to dc04d25e2f3f7e26f7f97b860992076b5f04afdb:

  hw/block/nvme: add support for the format nvm command (2021-03-18 12:41:43 +0100)

----------------------------------------------------------------
emulated nvme updates and fixes

* fixes for Coverity CID 1450756, 1450757 and 1450758 (me)
* fix for a bug in zone management receive (me)
* metadata and end-to-end data protection support (me & Gollu Appalanaidu)
* verify support (Gollu Appalanaidu)
* multiple lba formats and format nvm support (Minwoo Im)

and a couple of misc refactorings from me.

v2:
  - remove an unintended submodule update. Argh.

----------------------------------------------------------------

Gollu Appalanaidu (1):
  hw/block/nvme: add verify command

Klaus Jensen (8):
  hw/block/nvme: fix potential overflow
  hw/block/nvme: assert namespaces array indices
  hw/block/nvme: fix zone management receive reporting too many zones
  hw/block/nvme: add metadata support
  hw/block/nvme: end-to-end data protection
  hw/block/nvme: add non-mdts command size limit for verify
  hw/block/nvme: prefer runtime helpers instead of device parameters
  hw/block/nvme: pull lba format initialization

Minwoo Im (2):
  hw/block/nvme: support multiple lba formats
  hw/block/nvme: add support for the format nvm command

 hw/block/nvme-dif.h    |   53 ++
 hw/block/nvme-ns.h     |   50 +-
 hw/block/nvme-subsys.h |    2 +
 hw/block/nvme.h        |   44 +-
 include/block/nvme.h   |   29 +-
 hw/block/nvme-dif.c    |  508 ++++++++++++++++
 hw/block/nvme-ns.c     |  124 +++-
 hw/block/nvme-subsys.c |    7 +-
 hw/block/nvme.c        | 1257 ++++++++++++++++++++++++++++++++++++----
 hw/block/meson.build   |    2 +-
 hw/block/trace-events  |   22 +-
 11 files changed, 1939 insertions(+), 159 deletions(-)
 create mode 100644 hw/block/nvme-dif.h
 create mode 100644 hw/block/nvme-dif.c

Comments

Klaus Jensen March 18, 2021, noon UTC | #1
On Mar 18 12:57, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Hi Peter,
> 
> The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76:
> 
>   Merge remote-tracking branch 'remotes/vivier/tags/q800-for-6.0-pull-request' into staging (2021-03-18 10:05:37 +0000)
> 
> are available in the Git repository at:
> 
>   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
> 
> for you to fetch changes up to dc04d25e2f3f7e26f7f97b860992076b5f04afdb:
> 
>   hw/block/nvme: add support for the format nvm command (2021-03-18 12:41:43 +0100)
> 
> ----------------------------------------------------------------
> emulated nvme updates and fixes
> 
> * fixes for Coverity CID 1450756, 1450757 and 1450758 (me)
> * fix for a bug in zone management receive (me)
> * metadata and end-to-end data protection support (me & Gollu Appalanaidu)
> * verify support (Gollu Appalanaidu)
> * multiple lba formats and format nvm support (Minwoo Im)
> 
> and a couple of misc refactorings from me.
> 
> v2:
>   - remove an unintended submodule update. Argh.
> 
> ----------------------------------------------------------------
> 
> Gollu Appalanaidu (1):
>   hw/block/nvme: add verify command
> 
> Klaus Jensen (8):
>   hw/block/nvme: fix potential overflow
>   hw/block/nvme: assert namespaces array indices
>   hw/block/nvme: fix zone management receive reporting too many zones
>   hw/block/nvme: add metadata support
>   hw/block/nvme: end-to-end data protection
>   hw/block/nvme: add non-mdts command size limit for verify
>   hw/block/nvme: prefer runtime helpers instead of device parameters
>   hw/block/nvme: pull lba format initialization
> 
> Minwoo Im (2):
>   hw/block/nvme: support multiple lba formats
>   hw/block/nvme: add support for the format nvm command
> 
>  hw/block/nvme-dif.h    |   53 ++
>  hw/block/nvme-ns.h     |   50 +-
>  hw/block/nvme-subsys.h |    2 +
>  hw/block/nvme.h        |   44 +-
>  include/block/nvme.h   |   29 +-
>  hw/block/nvme-dif.c    |  508 ++++++++++++++++
>  hw/block/nvme-ns.c     |  124 +++-
>  hw/block/nvme-subsys.c |    7 +-
>  hw/block/nvme.c        | 1257 ++++++++++++++++++++++++++++++++++++----
>  hw/block/meson.build   |    2 +-
>  hw/block/trace-events  |   22 +-
>  11 files changed, 1939 insertions(+), 159 deletions(-)
>  create mode 100644 hw/block/nvme-dif.h
>  create mode 100644 hw/block/nvme-dif.c
> 
> -- 
> 2.30.1
> 

Following a convention I've seen on the list, I'm only re-sending the
cover letter since there are no changes to any of the patches, only the
tag.
Peter Maydell March 18, 2021, 11:03 p.m. UTC | #2
On Thu, 18 Mar 2021 at 11:58, Klaus Jensen <its@irrelevant.dk> wrote:
>
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Hi Peter,
>
> The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76:
>
>   Merge remote-tracking branch 'remotes/vivier/tags/q800-for-6.0-pull-request' into staging (2021-03-18 10:05:37 +0000)
>
> are available in the Git repository at:
>
>   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
>
> for you to fetch changes up to dc04d25e2f3f7e26f7f97b860992076b5f04afdb:
>
>   hw/block/nvme: add support for the format nvm command (2021-03-18 12:41:43 +0100)
>
> ----------------------------------------------------------------
> emulated nvme updates and fixes
>
> * fixes for Coverity CID 1450756, 1450757 and 1450758 (me)
> * fix for a bug in zone management receive (me)
> * metadata and end-to-end data protection support (me & Gollu Appalanaidu)
> * verify support (Gollu Appalanaidu)
> * multiple lba formats and format nvm support (Minwoo Im)
>
> and a couple of misc refactorings from me.
>
> v2:
>   - remove an unintended submodule update. Argh.


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM
Klaus Jensen March 22, 2021, 6:23 a.m. UTC | #3
On Mar 18 23:03, Peter Maydell wrote:
> On Thu, 18 Mar 2021 at 11:58, Klaus Jensen <its@irrelevant.dk> wrote:
> >
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > Hi Peter,
> >
> > The following changes since commit b12498fc575f2ad30f09fe78badc7fef526e2d76:
> >
> >   Merge remote-tracking branch 'remotes/vivier/tags/q800-for-6.0-pull-request' into staging (2021-03-18 10:05:37 +0000)
> >
> > are available in the Git repository at:
> >
> >   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
> >
> > for you to fetch changes up to dc04d25e2f3f7e26f7f97b860992076b5f04afdb:
> >
> >   hw/block/nvme: add support for the format nvm command (2021-03-18 12:41:43 +0100)
> >
> > ----------------------------------------------------------------
> > emulated nvme updates and fixes
> >
> > * fixes for Coverity CID 1450756, 1450757 and 1450758 (me)
> > * fix for a bug in zone management receive (me)
> > * metadata and end-to-end data protection support (me & Gollu Appalanaidu)
> > * verify support (Gollu Appalanaidu)
> > * multiple lba formats and format nvm support (Minwoo Im)
> >
> > and a couple of misc refactorings from me.
> >
> > v2:
> >   - remove an unintended submodule update. Argh.
> 
> 
> Applied, thanks.
> 
> Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
> for any user-visible changes.
> 
> -- PMM

Coverity reports two leaks in nvme_format_ns and nvme_dif_rw
respectively.

Fixes are submitted and I'll send a pull request ASAP.