| Message ID | 20210318200949.1387703-2-ckuehl@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iotests: fix 051.out expected output after error | expand |
On 18.03.21 21:09, Connor Kuehl wrote: > A patch was recently applied that touched up some error messages that > pertained to key names like 'node-name'. The trouble is it only updated > tests/qemu-iotests/051.pc.out and not tests/qemu-iotests/051.out as > well. > > Do that now. > > Fixes: 785ec4b1b9 ("block: Clarify error messages pertaining to > 'node-name'") > Signed-off-by: Connor Kuehl <ckuehl@redhat.com> Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> Thanks for the quick response. > --- > tests/qemu-iotests/051.out | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out > index de4771bcb3..db8c14b903 100644 > --- a/tests/qemu-iotests/051.out > +++ b/tests/qemu-iotests/051.out > @@ -61,13 +61,13 @@ QEMU X.Y.Z monitor - type 'help' for more information > (qemu) quit > > Testing: -drive file=TEST_DIR/t.qcow2,node-name=123foo > -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node name > +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node-name: '123foo' > > Testing: -drive file=TEST_DIR/t.qcow2,node-name=_foo > -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node name > +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node-name: '_foo' > > Testing: -drive file=TEST_DIR/t.qcow2,node-name=foo#12 > -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node name > +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node-name: 'foo#12' > > > === Device without drive === >
On 3/18/21 4:09 PM, Connor Kuehl wrote: > A patch was recently applied that touched up some error messages that > pertained to key names like 'node-name'. The trouble is it only updated > tests/qemu-iotests/051.pc.out and not tests/qemu-iotests/051.out as > well. > > Do that now. > > Fixes: 785ec4b1b9 ("block: Clarify error messages pertaining to > 'node-name'") > Signed-off-by: Connor Kuehl <ckuehl@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com> > --- > tests/qemu-iotests/051.out | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out > index de4771bcb3..db8c14b903 100644 > --- a/tests/qemu-iotests/051.out > +++ b/tests/qemu-iotests/051.out > @@ -61,13 +61,13 @@ QEMU X.Y.Z monitor - type 'help' for more information > (qemu) quit > > Testing: -drive file=TEST_DIR/t.qcow2,node-name=123foo > -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node name > +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node-name: '123foo' > > Testing: -drive file=TEST_DIR/t.qcow2,node-name=_foo > -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node name > +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node-name: '_foo' > > Testing: -drive file=TEST_DIR/t.qcow2,node-name=foo#12 > -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node name > +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node-name: 'foo#12' > > > === Device without drive === >
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out index de4771bcb3..db8c14b903 100644 --- a/tests/qemu-iotests/051.out +++ b/tests/qemu-iotests/051.out @@ -61,13 +61,13 @@ QEMU X.Y.Z monitor - type 'help' for more information (qemu) quit Testing: -drive file=TEST_DIR/t.qcow2,node-name=123foo -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node name +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=123foo: Invalid node-name: '123foo' Testing: -drive file=TEST_DIR/t.qcow2,node-name=_foo -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node name +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=_foo: Invalid node-name: '_foo' Testing: -drive file=TEST_DIR/t.qcow2,node-name=foo#12 -QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node name +QEMU_PROG: -drive file=TEST_DIR/t.qcow2,node-name=foo#12: Invalid node-name: 'foo#12' === Device without drive ===
A patch was recently applied that touched up some error messages that pertained to key names like 'node-name'. The trouble is it only updated tests/qemu-iotests/051.pc.out and not tests/qemu-iotests/051.out as well. Do that now. Fixes: 785ec4b1b9 ("block: Clarify error messages pertaining to 'node-name'") Signed-off-by: Connor Kuehl <ckuehl@redhat.com> --- tests/qemu-iotests/051.out | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)