mbox

[PULL,v4,0/6] QOM and fdc patches patches for 2021-03-16

Message ID 20210319064517.1496467-1-armbru@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16-v4

Message

Markus Armbruster March 19, 2021, 6:45 a.m. UTC
The following changes since commit 8a40754bca14df63c6d2ffe473b68a270dc50679:

  Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' into staging (2021-03-18 19:55:37 +0000)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16-v4

for you to fetch changes up to 0c727a621a646504ccec2b08e55fd48030448466:

  memory: Drop "qemu:" prefix from QOM memory region type names (2021-03-19 06:55:49 +0100)

----------------------------------------------------------------
QOM and fdc patches patches for 2021-03-16

----------------------------------------------------------------
Markus Armbruster (6):
      docs/system/deprecated: Fix note on fdc drive properties
      fdc: Drop deprecated floppy configuration
      fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()
      blockdev: Drop deprecated bogus -drive interface type
      hw: Replace anti-social QOM type names
      memory: Drop "qemu:" prefix from QOM memory region type names

 docs/system/deprecated.rst                   |  33 --
 docs/system/removed-features.rst             |  57 +++
 include/exec/memory.h                        |   4 +-
 include/hw/arm/armv7m.h                      |   2 +-
 include/hw/arm/fsl-imx25.h                   |   2 +-
 include/hw/arm/fsl-imx31.h                   |   2 +-
 include/hw/arm/fsl-imx6.h                    |   2 +-
 include/hw/arm/fsl-imx6ul.h                  |   2 +-
 include/hw/arm/fsl-imx7.h                    |   2 +-
 include/hw/arm/xlnx-zynqmp.h                 |   2 +-
 include/hw/cris/etraxfs.h                    |   2 +-
 include/hw/i386/ich9.h                       |   2 +-
 include/hw/misc/grlib_ahb_apb_pnp.h          |   4 +-
 include/hw/misc/zynq-xadc.h                  |   2 +-
 include/hw/register.h                        |   2 +-
 include/hw/sparc/grlib.h                     |   6 +-
 include/sysemu/blockdev.h                    |   1 -
 blockdev.c                                   |  37 +-
 hw/arm/xilinx_zynq.c                         |   2 +-
 hw/audio/cs4231.c                            |   2 +-
 hw/block/fdc.c                               |  77 +---
 hw/char/etraxfs_ser.c                        |   2 +-
 hw/cris/axis_dev88.c                         |   6 +-
 hw/display/tcx.c                             |   2 +-
 hw/intc/etraxfs_pic.c                        |   2 +-
 hw/microblaze/xlnx-zynqmp-pmu.c              |   2 +-
 hw/misc/zynq_slcr.c                          |   2 +-
 hw/sparc/sun4m.c                             |  12 +-
 hw/timer/etraxfs_timer.c                     |   2 +-
 softmmu/vl.c                                 |  10 +-
 tests/qemu-iotests/172                       |  31 +-
 tests/qemu-iotests/172.out                   | 562 +--------------------------
 tests/vmstate-static-checker-data/dump1.json |   4 +-
 tests/vmstate-static-checker-data/dump2.json |   4 +-
 34 files changed, 125 insertions(+), 761 deletions(-)

Comments

Peter Maydell March 19, 2021, 11:26 a.m. UTC | #1
On Fri, 19 Mar 2021 at 06:45, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit 8a40754bca14df63c6d2ffe473b68a270dc50679:
>
>   Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' into staging (2021-03-18 19:55:37 +0000)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16-v4
>
> for you to fetch changes up to 0c727a621a646504ccec2b08e55fd48030448466:
>
>   memory: Drop "qemu:" prefix from QOM memory region type names (2021-03-19 06:55:49 +0100)
>
> ----------------------------------------------------------------
> QOM and fdc patches patches for 2021-03-16
>
> ----------------------------------------------------------------
> Markus Armbruster (6):
>       docs/system/deprecated: Fix note on fdc drive properties
>       fdc: Drop deprecated floppy configuration
>       fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()
>       blockdev: Drop deprecated bogus -drive interface type
>       hw: Replace anti-social QOM type names
>       memory: Drop "qemu:" prefix from QOM memory region type name

Looks like this breaks the sanitizer gitlab CI job:
 https://gitlab.com/qemu-project/qemu/-/jobs/1111697105

Testing ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3
...
==8556==WARNING: ASan doesn't fully support makecontext/swapcontext
functions and may produce false positives in some cases!
==8556==WARNING: ASan is ignoring requested __asan_handle_no_return:
stack type: default top: 0x7ffcb7805000; bottom 0x7f960e9fd000; size:
0x0066a8e08000 (440919949312)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive:
machine type does not support if=sd,bus=0,unit=0

thanks
-- PMM
Markus Armbruster March 19, 2021, 1:03 p.m. UTC | #2
Peter Maydell <peter.maydell@linaro.org> writes:

> On Fri, 19 Mar 2021 at 06:45, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> The following changes since commit 8a40754bca14df63c6d2ffe473b68a270dc50679:
>>
>>   Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' into staging (2021-03-18 19:55:37 +0000)
>>
>> are available in the Git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-qom-fdc-2021-03-16-v4
>>
>> for you to fetch changes up to 0c727a621a646504ccec2b08e55fd48030448466:
>>
>>   memory: Drop "qemu:" prefix from QOM memory region type names (2021-03-19 06:55:49 +0100)
>>
>> ----------------------------------------------------------------
>> QOM and fdc patches patches for 2021-03-16
>>
>> ----------------------------------------------------------------
>> Markus Armbruster (6):
>>       docs/system/deprecated: Fix note on fdc drive properties
>>       fdc: Drop deprecated floppy configuration
>>       fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()
>>       blockdev: Drop deprecated bogus -drive interface type
>>       hw: Replace anti-social QOM type names
>>       memory: Drop "qemu:" prefix from QOM memory region type name
>
> Looks like this breaks the sanitizer gitlab CI job:
>  https://gitlab.com/qemu-project/qemu/-/jobs/1111697105
>
> Testing ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-generic-fuzz-sdhci-v3
> ...
> ==8556==WARNING: ASan doesn't fully support makecontext/swapcontext
> functions and may produce false positives in some cases!
> ==8556==WARNING: ASan is ignoring requested __asan_handle_no_return:
> stack type: default top: 0x7ffcb7805000; bottom 0x7f960e9fd000; size:
> 0x0066a8e08000 (440919949312)
> False positive error reports may follow
> For details see https://github.com/google/sanitizers/issues/189
> i386: -drive if=sd,index=0,file=null-co://,format=raw,id=mydrive:
> machine type does not support if=sd,bus=0,unit=0

In tests/qtest/fuzz/generic_fuzz_configs.h:

    },{
        .name = "sdhci-v3",
        .args = "-nodefaults -device sdhci-pci,sd-spec-version=3 "
        "-device sd-card,drive=mydrive "
        "-drive if=sd,index=0,file=null-co://,format=raw,id=mydrive -nographic",
        .objects = "sd*"
    },{

The if=sd needs to be if=none.

Before this series, the test prints a deprecation warning.  Since it
also prints lots of other junk, nobody noticed.

After this series removed the deprecated misfeature, the test fails.

v5 coming.