[v4,17/19] qapi/expr.py: Use tuples instead of lists for static data

Commit Message

John Snow March 25, 2021, 6:03 a.m. UTC

It is -- maybe -- possibly -- three nanoseconds faster.

Signed-off-by: John Snow <[e-mail]>
Reviewed-by: Eduardo Habkost <[e-mail]>
Reviewed-by: Cleber Rosa <[e-mail]>

---

This can be dropped if desired; it has no real functional impact I could
defend in code review court. I just happened to write it this way.

Signed-off-by: John Snow <[e-mail]>
---
 scripts/qapi/expr.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Markus Armbruster March 25, 2021, 3:19 p.m. UTC | #1

John Snow <[e-mail]> writes:

> It is -- maybe -- possibly -- three nanoseconds faster.
>
> Signed-off-by: John Snow <[e-mail]>
> Reviewed-by: Eduardo Habkost <[e-mail]>
> Reviewed-by: Cleber Rosa <[e-mail]>
>
> ---
>
> This can be dropped if desired; it has no real functional impact I could
> defend in code review court. I just happened to write it this way.

I'm fine with taking this.  Could it go right after PATCH 11?  If not,
no big deal.

Patch

diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index adc5b903bc..b11c11b965 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -210,11 +210,11 @@  def check_flags(expr: _JSONObject, info: QAPISourceInfo) -> None:
     :param expr: Expression to validate.
     :param info: QAPI source file information.
     """
-    for key in ['gen', 'success-response']:
+    for key in ('gen', 'success-response'):
         if key in expr and expr[key] is not False:
             raise QAPISemError(
                 info, "flag '%s' may only use false value" % key)
-    for key in ['boxed', 'allow-oob', 'allow-preconfig', 'coroutine']:
+    for key in ('boxed', 'allow-oob', 'allow-preconfig', 'coroutine'):
         if key in expr and expr[key] is not True:
             raise QAPISemError(
                 info, "flag '%s' may only use true value" % key)