diff mbox series

[v4,01/19] qapi/expr: Comment cleanup

Message ID 20210325060356.4040114-2-jsnow@redhat.com (mailing list archive)
State New, archived
Headers show
Series qapi: static typing conversion, pt3 | expand

Commit Message

John Snow March 25, 2021, 6:03 a.m. UTC
Fixes: 0825f62c842

Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/qapi/expr.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Armbruster March 25, 2021, 3:41 p.m. UTC | #1
John Snow <jsnow@redhat.com> writes:

> Fixes: 0825f62c842

For a slightly peculiar value of "fixes" ;)

> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  scripts/qapi/expr.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
> index 540b3982b1..c207481f7e 100644
> --- a/scripts/qapi/expr.py
> +++ b/scripts/qapi/expr.py
> @@ -241,7 +241,7 @@ def check_enum(expr, info):
>          source = "%s '%s'" % (source, member_name)
>          # Enum members may start with a digit
>          if member_name[0].isdigit():
> -            member_name = 'd' + member_name # Hack: hide the digit
> +            member_name = 'd' + member_name  # Hack: hide the digit
>          check_name_lower(member_name, info, source,
>                           permit_upper=permissive,
>                           permit_underscore=permissive)
John Snow March 25, 2021, 8:06 p.m. UTC | #2
On 3/25/21 11:41 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
> 
>> Fixes: 0825f62c842
> 
> For a slightly peculiar value of "fixes" ;)
> 

Less of this, please.
diff mbox series

Patch

diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 540b3982b1..c207481f7e 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -241,7 +241,7 @@  def check_enum(expr, info):
         source = "%s '%s'" % (source, member_name)
         # Enum members may start with a digit
         if member_name[0].isdigit():
-            member_name = 'd' + member_name # Hack: hide the digit
+            member_name = 'd' + member_name  # Hack: hide the digit
         check_name_lower(member_name, info, source,
                          permit_upper=permissive,
                          permit_underscore=permissive)