diff mbox series

[PULL,for-6.0,3/7] hw/block/nvme: fix the nsid 'invalid' value

Message ID 20210406204627.140812-4-its@irrelevant.dk (mailing list archive)
State New, archived
Headers show
Series [PULL,for-6.0,1/7] hw/block/nvme: fix pi constraint check | expand

Commit Message

Klaus Jensen April 6, 2021, 8:46 p.m. UTC
From: Klaus Jensen <k.jensen@samsung.com>

The `nvme_nsid()` function returns '-1' (FFFFFFFFh) when the given
namespace is NULL. Since FFFFFFFFh is actually a valid namespace
identifier (the "broadcast" value), change this to be '0' since that
actually *is* the invalid value.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
 hw/block/nvme-ns.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h
index 9ab7894fc83e..82340c4b2574 100644
--- a/hw/block/nvme-ns.h
+++ b/hw/block/nvme-ns.h
@@ -96,7 +96,7 @@  static inline uint32_t nvme_nsid(NvmeNamespace *ns)
         return ns->params.nsid;
-    return -1;
+    return 0;
 static inline bool nvme_ns_shared(NvmeNamespace *ns)