mbox

[PULL,0/6] migration + virtiofsd queue

Message ID 20210407102021.95225-1-dgilbert@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

git://github.com/dagrh/qemu.git tags/pull-migration-20210407a

Message

Dr. David Alan Gilbert April 7, 2021, 10:20 a.m. UTC
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The following changes since commit d0d3dd401b70168a353450e031727affee828527:

  Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)

are available in the Git repository at:

  git://github.com/dagrh/qemu.git tags/pull-migration-20210407a

for you to fetch changes up to c4e232bb57aca19ca60f692ee830023a76eca78e:

  tests/migration: fix parameter of auto-converge migration (2021-04-06 18:56:02 +0100)

----------------------------------------------------------------
migration+virtiofs fixes pull 2021-04-07

A seg fix in virtiofsd, a bunch of fixes for background snapshots, and
a migration test fix.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

----------------------------------------------------------------
Andrey Gruzdev (4):
      migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread
      migration: Inhibit virtio-balloon for the duration of background snapshot
      migration: Pre-fault memory before starting background snasphot
      migration: Rename 'bs' to 'block' in background snapshot code

Dr. David Alan Gilbert (1):
      virtiofsd: Fix security.capability comparison

Hyman Huang(黄勇) (1):
      tests/migration: fix parameter of auto-converge migration

 hw/virtio/virtio-balloon.c          |   8 ++-
 include/migration/misc.h            |   2 +
 migration/migration.c               |  22 ++++++-
 migration/ram.c                     | 119 +++++++++++++++++++++++++-----------
 migration/ram.h                     |   1 +
 tests/migration/guestperf/engine.py |   4 +-
 tools/virtiofsd/passthrough_ll.c    |   3 +-
 7 files changed, 119 insertions(+), 40 deletions(-)

Comments

Peter Maydell April 7, 2021, 1:25 p.m. UTC | #1
On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
>
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The following changes since commit d0d3dd401b70168a353450e031727affee828527:
>
>   Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/dagrh/qemu.git tags/pull-migration-20210407a
>
> for you to fetch changes up to c4e232bb57aca19ca60f692ee830023a76eca78e:
>
>   tests/migration: fix parameter of auto-converge migration (2021-04-06 18:56:02 +0100)
>
> ----------------------------------------------------------------
> migration+virtiofs fixes pull 2021-04-07
>
> A seg fix in virtiofsd, a bunch of fixes for background snapshots, and
> a migration test fix.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> ----------------------------------------------------------------

Fails to link on non-Linux hosts:

Undefined symbols for architecture x86_64:
  "_ram_write_tracking_prepare", referenced from:
      _bg_migration_thread in migration_migration.c.o
ld: symbol(s) not found for architecture x86_64

The definition of ram_write_tracking_prepare() is inside an
#if defined(__linux__), but the callsite is not, I think.

thanks
-- PMM
Dr. David Alan Gilbert April 7, 2021, 4:50 p.m. UTC | #2
* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git)
> <dgilbert@redhat.com> wrote:
> >
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > The following changes since commit d0d3dd401b70168a353450e031727affee828527:
> >
> >   Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://github.com/dagrh/qemu.git tags/pull-migration-20210407a
> >
> > for you to fetch changes up to c4e232bb57aca19ca60f692ee830023a76eca78e:
> >
> >   tests/migration: fix parameter of auto-converge migration (2021-04-06 18:56:02 +0100)
> >
> > ----------------------------------------------------------------
> > migration+virtiofs fixes pull 2021-04-07
> >
> > A seg fix in virtiofsd, a bunch of fixes for background snapshots, and
> > a migration test fix.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > ----------------------------------------------------------------
> 
> Fails to link on non-Linux hosts:
> 
> Undefined symbols for architecture x86_64:
>   "_ram_write_tracking_prepare", referenced from:
>       _bg_migration_thread in migration_migration.c.o
> ld: symbol(s) not found for architecture x86_64
> 
> The definition of ram_write_tracking_prepare() is inside an
> #if defined(__linux__), but the callsite is not, I think.

OK, reproduced here.  Let me see.

Dave

> thanks
> -- PMM
>
Andrey Gruzdev April 8, 2021, 9:16 a.m. UTC | #3
On 07.04.2021 19:50, Dr. David Alan Gilbert wrote:
> * Peter Maydell (peter.maydell@linaro.org) wrote:
>> On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git)
>> <dgilbert@redhat.com> wrote:
>>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>>
>>> The following changes since commit d0d3dd401b70168a353450e031727affee828527:
>>>
>>>    Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>    git://github.com/dagrh/qemu.git tags/pull-migration-20210407a
>>>
>>> for you to fetch changes up to c4e232bb57aca19ca60f692ee830023a76eca78e:
>>>
>>>    tests/migration: fix parameter of auto-converge migration (2021-04-06 18:56:02 +0100)
>>>
>>> ----------------------------------------------------------------
>>> migration+virtiofs fixes pull 2021-04-07
>>>
>>> A seg fix in virtiofsd, a bunch of fixes for background snapshots, and
>>> a migration test fix.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>>
>>> ----------------------------------------------------------------
>> Fails to link on non-Linux hosts:
>>
>> Undefined symbols for architecture x86_64:
>>    "_ram_write_tracking_prepare", referenced from:
>>        _bg_migration_thread in migration_migration.c.o
>> ld: symbol(s) not found for architecture x86_64
>>
>> The definition of ram_write_tracking_prepare() is inside an
>> #if defined(__linux__), but the callsite is not, I think.
> OK, reproduced here.  Let me see.
>
> Dave
>
Seems that non-linux stub is missing, I'll respin.

>> thanks
>> -- PMM
>>
Dr. David Alan Gilbert April 8, 2021, 10:50 a.m. UTC | #4
* Andrey Gruzdev (andrey.gruzdev@virtuozzo.com) wrote:
> On 07.04.2021 19:50, Dr. David Alan Gilbert wrote:
> > * Peter Maydell (peter.maydell@linaro.org) wrote:
> > > On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git)
> > > <dgilbert@redhat.com> wrote:
> > > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > > > 
> > > > The following changes since commit d0d3dd401b70168a353450e031727affee828527:
> > > > 
> > > >    Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)
> > > > 
> > > > are available in the Git repository at:
> > > > 
> > > >    git://github.com/dagrh/qemu.git tags/pull-migration-20210407a
> > > > 
> > > > for you to fetch changes up to c4e232bb57aca19ca60f692ee830023a76eca78e:
> > > > 
> > > >    tests/migration: fix parameter of auto-converge migration (2021-04-06 18:56:02 +0100)
> > > > 
> > > > ----------------------------------------------------------------
> > > > migration+virtiofs fixes pull 2021-04-07
> > > > 
> > > > A seg fix in virtiofsd, a bunch of fixes for background snapshots, and
> > > > a migration test fix.
> > > > 
> > > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > > 
> > > > ----------------------------------------------------------------
> > > Fails to link on non-Linux hosts:
> > > 
> > > Undefined symbols for architecture x86_64:
> > >    "_ram_write_tracking_prepare", referenced from:
> > >        _bg_migration_thread in migration_migration.c.o
> > > ld: symbol(s) not found for architecture x86_64
> > > 
> > > The definition of ram_write_tracking_prepare() is inside an
> > > #if defined(__linux__), but the callsite is not, I think.
> > OK, reproduced here.  Let me see.
> > 
> > Dave
> > 
> Seems that non-linux stub is missing, I'll respin.

I posted a v2 pull with an extra ifdef, lets get that in, and we can
tidy the stub in later.

Dave

> > > thanks
> > > -- PMM
> > > 
> 
> 
> -- 
> Andrey Gruzdev, Principal Engineer
> Virtuozzo GmbH  +7-903-247-6397
>                 virtuzzo.com
>
Andrey Gruzdev April 8, 2021, 12:27 p.m. UTC | #5
On 08.04.2021 13:50, Dr. David Alan Gilbert wrote:
> * Andrey Gruzdev (andrey.gruzdev@virtuozzo.com) wrote:
>> On 07.04.2021 19:50, Dr. David Alan Gilbert wrote:
>>> * Peter Maydell (peter.maydell@linaro.org) wrote:
>>>> On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git)
>>>> <dgilbert@redhat.com> wrote:
>>>>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>>>>
>>>>> The following changes since commit d0d3dd401b70168a353450e031727affee828527:
>>>>>
>>>>>     Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>     git://github.com/dagrh/qemu.git tags/pull-migration-20210407a
>>>>>
>>>>> for you to fetch changes up to c4e232bb57aca19ca60f692ee830023a76eca78e:
>>>>>
>>>>>     tests/migration: fix parameter of auto-converge migration (2021-04-06 18:56:02 +0100)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> migration+virtiofs fixes pull 2021-04-07
>>>>>
>>>>> A seg fix in virtiofsd, a bunch of fixes for background snapshots, and
>>>>> a migration test fix.
>>>>>
>>>>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>>>>
>>>>> ----------------------------------------------------------------
>>>> Fails to link on non-Linux hosts:
>>>>
>>>> Undefined symbols for architecture x86_64:
>>>>     "_ram_write_tracking_prepare", referenced from:
>>>>         _bg_migration_thread in migration_migration.c.o
>>>> ld: symbol(s) not found for architecture x86_64
>>>>
>>>> The definition of ram_write_tracking_prepare() is inside an
>>>> #if defined(__linux__), but the callsite is not, I think.
>>> OK, reproduced here.  Let me see.
>>>
>>> Dave
>>>
>> Seems that non-linux stub is missing, I'll respin.
> I posted a v2 pull with an extra ifdef, lets get that in, and we can
> tidy the stub in later.
>
> Dave

Ok

>>>> thanks
>>>> -- PMM
>>>>
>>
>> -- 
>> Andrey Gruzdev, Principal Engineer
>> Virtuozzo GmbH  +7-903-247-6397
>>                  virtuzzo.com
>>