| Message ID | 20210408195237.3489296-3-wainersm@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/acceptance: Handle tests with "cpu" tag | expand |
On Thu, Apr 08, 2021 at 04:52:32PM -0300, Wainer dos Santos Moschetta wrote: > There are test cases on machine_mips_malta.py and tcg_plugins.py files > where the cpu tag does not correspond to the value actually given to the QEMU > binary. This fixed those tests tags. > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > --- > tests/acceptance/machine_mips_malta.py | 6 +++--- > tests/acceptance/tcg_plugins.py | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/acceptance/machine_mips_malta.py b/tests/acceptance/machine_mips_malta.py > index 7c9a4ee4d2..b1fd075f51 100644 > --- a/tests/acceptance/machine_mips_malta.py > +++ b/tests/acceptance/machine_mips_malta.py > @@ -96,7 +96,7 @@ def test_mips_malta_i6400_framebuffer_logo_1core(self): > """ > :avocado: tags=arch:mips64el > :avocado: tags=machine:malta > - :avocado: tags=cpu:i6400 > + :avocado: tags=cpu:I6400 > """ > self.do_test_i6400_framebuffer_logo(1) > > @@ -105,7 +105,7 @@ def test_mips_malta_i6400_framebuffer_logo_7cores(self): > """ > :avocado: tags=arch:mips64el > :avocado: tags=machine:malta > - :avocado: tags=cpu:i6400 > + :avocado: tags=cpu:I6400 > :avocado: tags=mips:smp > """ > self.do_test_i6400_framebuffer_logo(7) > @@ -115,7 +115,7 @@ def test_mips_malta_i6400_framebuffer_logo_8cores(self): > """ > :avocado: tags=arch:mips64el > :avocado: tags=machine:malta > - :avocado: tags=cpu:i6400 > + :avocado: tags=cpu:I6400 > :avocado: tags=mips:smp > """ What about also changing the test names for consistency? > self.do_test_i6400_framebuffer_logo(8) > diff --git a/tests/acceptance/tcg_plugins.py b/tests/acceptance/tcg_plugins.py > index c21bf9e52a..aa6e18b62d 100644 > --- a/tests/acceptance/tcg_plugins.py > +++ b/tests/acceptance/tcg_plugins.py > @@ -68,7 +68,7 @@ def test_aarch64_virt_insn(self): > :avocado: tags=accel:tcg > :avocado: tags=arch:aarch64 > :avocado: tags=machine:virt > - :avocado: tags=cpu:cortex-a57 > + :avocado: tags=cpu:cortex-a53 > """ > kernel_path = self._grab_aarch64_kernel() > kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + > @@ -95,7 +95,7 @@ def test_aarch64_virt_insn_icount(self): > :avocado: tags=accel:tcg > :avocado: tags=arch:aarch64 > :avocado: tags=machine:virt > - :avocado: tags=cpu:cortex-a57 > + :avocado: tags=cpu:cortex-a53 > """ > kernel_path = self._grab_aarch64_kernel() > kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + > @@ -121,7 +121,7 @@ def test_aarch64_virt_mem_icount(self): > :avocado: tags=accel:tcg > :avocado: tags=arch:aarch64 > :avocado: tags=machine:virt > - :avocado: tags=cpu:cortex-a57 > + :avocado: tags=cpu:cortex-a53 > """ > kernel_path = self._grab_aarch64_kernel() > kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + > -- > 2.29.2 > Despite the suggestion, this is working fine: JOB ID : 90e4ddaa4f5b7d2b7d53f9f7a7300e9e9a94e8f4 JOB LOG : /home/cleber/avocado/job-results/job-2021-04-21T17.05-90e4dda/job.log (1/6) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_1core: PASS (3.59 s) (2/6) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_7cores: PASS (16.54 s) (3/6) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_8cores: PASS (17.95 s) (4/6) tests/acceptance/tcg_plugins.py:PluginKernelNormal.test_aarch64_virt_insn: PASS (17.05 s) (5/6) tests/acceptance/tcg_plugins.py:PluginKernelNormal.test_aarch64_virt_insn_icount: PASS (14.94 s) (6/6) tests/acceptance/tcg_plugins.py:PluginKernelNormal.test_aarch64_virt_mem_icount: PASS (14.39 s) RESULTS : PASS 6 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0 JOB TIME : 87.47 s Reviewed-by: Cleber Rosa <crosa@redhat.com> Tested-by: Cleber Rosa <crosa@redhat.com>
On Thu, Apr 8, 2021 at 5:00 PM Wainer dos Santos Moschetta <wainersm@redhat.com> wrote: > > There are test cases on machine_mips_malta.py and tcg_plugins.py files > where the cpu tag does not correspond to the value actually given to the QEMU > binary. This fixed those tests tags. > > Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > --- > tests/acceptance/machine_mips_malta.py | 6 +++--- > tests/acceptance/tcg_plugins.py | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
diff --git a/tests/acceptance/machine_mips_malta.py b/tests/acceptance/machine_mips_malta.py index 7c9a4ee4d2..b1fd075f51 100644 --- a/tests/acceptance/machine_mips_malta.py +++ b/tests/acceptance/machine_mips_malta.py @@ -96,7 +96,7 @@ def test_mips_malta_i6400_framebuffer_logo_1core(self): """ :avocado: tags=arch:mips64el :avocado: tags=machine:malta - :avocado: tags=cpu:i6400 + :avocado: tags=cpu:I6400 """ self.do_test_i6400_framebuffer_logo(1) @@ -105,7 +105,7 @@ def test_mips_malta_i6400_framebuffer_logo_7cores(self): """ :avocado: tags=arch:mips64el :avocado: tags=machine:malta - :avocado: tags=cpu:i6400 + :avocado: tags=cpu:I6400 :avocado: tags=mips:smp """ self.do_test_i6400_framebuffer_logo(7) @@ -115,7 +115,7 @@ def test_mips_malta_i6400_framebuffer_logo_8cores(self): """ :avocado: tags=arch:mips64el :avocado: tags=machine:malta - :avocado: tags=cpu:i6400 + :avocado: tags=cpu:I6400 :avocado: tags=mips:smp """ self.do_test_i6400_framebuffer_logo(8) diff --git a/tests/acceptance/tcg_plugins.py b/tests/acceptance/tcg_plugins.py index c21bf9e52a..aa6e18b62d 100644 --- a/tests/acceptance/tcg_plugins.py +++ b/tests/acceptance/tcg_plugins.py @@ -68,7 +68,7 @@ def test_aarch64_virt_insn(self): :avocado: tags=accel:tcg :avocado: tags=arch:aarch64 :avocado: tags=machine:virt - :avocado: tags=cpu:cortex-a57 + :avocado: tags=cpu:cortex-a53 """ kernel_path = self._grab_aarch64_kernel() kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + @@ -95,7 +95,7 @@ def test_aarch64_virt_insn_icount(self): :avocado: tags=accel:tcg :avocado: tags=arch:aarch64 :avocado: tags=machine:virt - :avocado: tags=cpu:cortex-a57 + :avocado: tags=cpu:cortex-a53 """ kernel_path = self._grab_aarch64_kernel() kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + @@ -121,7 +121,7 @@ def test_aarch64_virt_mem_icount(self): :avocado: tags=accel:tcg :avocado: tags=arch:aarch64 :avocado: tags=machine:virt - :avocado: tags=cpu:cortex-a57 + :avocado: tags=cpu:cortex-a53 """ kernel_path = self._grab_aarch64_kernel() kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
There are test cases on machine_mips_malta.py and tcg_plugins.py files where the cpu tag does not correspond to the value actually given to the QEMU binary. This fixed those tests tags. Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com> --- tests/acceptance/machine_mips_malta.py | 6 +++--- tests/acceptance/tcg_plugins.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)