From patchwork Tue Apr 13 10:11:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12200019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5D8C433B4 for ; Tue, 13 Apr 2021 10:14:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1CF8613B7 for ; Tue, 13 Apr 2021 10:14:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1CF8613B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWG46-000179-Tp for qemu-devel@archiver.kernel.org; Tue, 13 Apr 2021 06:14:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWG1T-0006NT-UC for qemu-devel@nongnu.org; Tue, 13 Apr 2021 06:11:55 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:33619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWG1S-0004p7-FS for qemu-devel@nongnu.org; Tue, 13 Apr 2021 06:11:55 -0400 Received: by mail-wr1-x42b.google.com with SMTP id f12so15888792wro.0 for ; Tue, 13 Apr 2021 03:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OjQxr/jFzbomVhE1MW9X6lY8//4Qu15uyh6N5jl5uwI=; b=fWg2n4QMGc/XXR8TtpILiRQdgOgZQHoUDz1QoS3jf2Pmj0u4btAIbBI+ap6Y9rp1xg EBOtngIp+fDjsvYtcmzOuRB7Td8ktrB0iyfYJdgURpD/HPi+gNSHnN1ieYx3NBvzyX52 n7y9UXdGt3V9sQ0/idZ4QXM3S4N7Bv+AgZ6uGZvSJumzD1v438+NxRQ2gWKBF1RTAz4C 8z9AfaLWUztnbCbND+zQHHaPfocVqXCvVhH1GOPxnuCcGtszDdIP8lRSWGHHIuj9z+aK KbsGeiXVC+QOTKT60IdfCHbApVX4SdB75CnwDGeR/dQaHeggHJ6lK/G5v8xZ6V9fHOaO 9mhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OjQxr/jFzbomVhE1MW9X6lY8//4Qu15uyh6N5jl5uwI=; b=ipgF5bf+O5zln1gCAHQxluWScuCx+0hiM0r6snpNHkpJY5NwqvIY+zmjhFPSTxYIba GIuIUKVONBra8PNiFw34C8RXMdDgUOjnWXFyfB37mb2jn/lMLgCJtaeIMqYbMmUmurGw deE00fnh8dEdIremgTP4pP4Kr1Cs+qh0YA6qOy57h6QFF3yqpcJms355rIZJ/U/9RbbV gDhD0qLa/tJdGTzJUyM3BeYb4dqVoUuueYYjHdv3QRv/ZdrEGA4+L3xg0+6wCj+LvrUJ HkCEtUoDkRIttx+hckyC9aUud9x/oDpATcpBBDTYdg22VSeV61H1drjslxpPAw+Hlok7 1CNA== X-Gm-Message-State: AOAM533Qo/W9deYtCVgoFmBilea5VD038O1cLsiT3NKos9det6E1K0Gk I8uZAlKGOjw0JIQN/eSJLIMS0LkFlmI= X-Google-Smtp-Source: ABdhPJxnYNeDJkqc6fq5vGm7SdWiXySvTbDgd1wOSmYrl7TH/hb8Vikfsy3IBJuygD+MoMjD8wUk5w== X-Received: by 2002:a5d:658c:: with SMTP id q12mr35645779wru.30.1618308713052; Tue, 13 Apr 2021 03:11:53 -0700 (PDT) Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id x14sm19275847wrw.13.2021.04.13.03.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 03:11:52 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 3/3] target/mips: Fix TCG temporary leak in gen_cache_operation() Date: Tue, 13 Apr 2021 12:11:31 +0200 Message-Id: <20210413101131.3480173-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210413101131.3480173-1-f4bug@amsat.org> References: <20210413101131.3480173-1-f4bug@amsat.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , =?utf-8?q?Herv=C3=A9_Poussineau?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fix a TCG temporary leak when translating CACHE opcode. Fixes: 0d74a222c27 ("make ITC Configuration Tags accessible to the CPU") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210406202857.1440744-1-f4bug@amsat.org> --- target/mips/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/translate.c b/target/mips/translate.c index c518bf3963b..71fa5ec1973 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -12804,6 +12804,8 @@ static void gen_cache_operation(DisasContext *ctx, uint32_t op, int base, TCGv t1 = tcg_temp_new(); gen_base_offset_addr(ctx, t1, base, offset); gen_helper_cache(cpu_env, t1, t0); + tcg_temp_free(t1); + tcg_temp_free_i32(t0); } #if defined(TARGET_MIPS64)