[v3,6/6] tests/meson: Only build softfloat objects if TCG is selected

Commit Message

Philippe Mathieu-Daudé April 15, 2021, 12:26 p.m. UTC

From: Philippe Mathieu-Daudé <[e-mail]>

The previous attempt (commit f77147cd4de) doesn't work as
expected, as we still have CONFIG_TCG=1 when using:

  configure --disable-system --disable-user

Now than we have removed the use of CONFIG_TCG from target-dependent
files in tests/qtest/, we can remove the unconditional definition of
CONFIG_TCG in config_host.

This avoid to build a bunch of unrequired objects when building with
--disable-tcg (in particular the softfloat tests):

Before:

  $ make
  [1/812] Generating trace-qom.h with a custom command
  ...

After:

  $ make
  [1/349] Generating trace-qom.h with a custom command
  ...

A difference of 463 objects...

Reported-by: Claudio Fontana <[e-mail]>
Suggested-by: Paolo Bonzini <[e-mail]>
Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
v3: Include Paolo's feedback:
https://www.mail-archive.com/[e-mail]/msg793872.html
therefore o not include Alex's R-b tag.

Cc: Richard Henderson <[e-mail]>
Cc: Alex Bennée <[e-mail]>
Cc: Emilio G. Cota <[e-mail]>
---
 meson.build | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/meson.build b/meson.build
index c6f4b0cf5e8..623cbe50685 100644
--- a/meson.build
+++ b/meson.build
@@ -262,7 +262,6 @@ 
                         language: ['c', 'cpp', 'objc'])
 
   accelerators += 'CONFIG_TCG'
-  config_host += { 'CONFIG_TCG': 'y' }
 endif
 
 if 'CONFIG_KVM' not in accelerators and get_option('kvm').enabled()