| Message ID | 20210422115430.15078-14-cfontana@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x cleanup | expand |
On Thu, 22 Apr 2021 13:54:30 +0200 Claudio Fontana <cfontana@suse.de> wrote: > After the reshuffling, update MAINTAINERS accordingly. > Make use of the new directories: > > target/s390x/kvm/ > target/s390x/tcg/ Is there anything left in target/s390x/ that is neither in kvm/ nor in tcg/? It seems that will only be covered by the general s390 maintainers entry. > > Signed-off-by: Claudio Fontana <cfontana@suse.de> > --- > MAINTAINERS | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7de873c9f5..3d738bd4fc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -315,7 +315,7 @@ S390 TCG CPUs > M: Richard Henderson <richard.henderson@linaro.org> > M: David Hildenbrand <david@redhat.com> > S: Maintained > -F: target/s390x/ > +F: target/s390x/tcg > F: hw/s390x/ Unrelated: I'm wondering how much sense it makes to have the whole of hw/s390x/ under the tcg section... but if the maintainers are not complaining, I'm happy to leave it there :) > F: disas/s390.c > F: tests/tcg/s390x/ > @@ -417,14 +417,12 @@ M: Halil Pasic <pasic@linux.ibm.com> > M: Cornelia Huck <cohuck@redhat.com> > M: Christian Borntraeger <borntraeger@de.ibm.com> > S: Supported > -F: target/s390x/kvm.c > -F: target/s390x/kvm_s390x.h > -F: target/s390x/kvm-stub.c > +F: target/s390x/kvm/ > F: target/s390x/ioinst.[ch] > F: target/s390x/machine.c > F: target/s390x/sigp.c > F: target/s390x/cpu_features*.[ch] > -F: target/s390x/cpu_models.[ch] > +F: target/s390x/cpu_models*.[ch] > F: hw/s390x/pv.c > F: include/hw/s390x/pv.h > F: hw/intc/s390_flic.c
Hello Cornelia, On 4/27/21 5:00 PM, Cornelia Huck wrote: > On Thu, 22 Apr 2021 13:54:30 +0200 > Claudio Fontana <cfontana@suse.de> wrote: > >> After the reshuffling, update MAINTAINERS accordingly. >> Make use of the new directories: >> >> target/s390x/kvm/ >> target/s390x/tcg/ > > Is there anything left in target/s390x/ that is neither in kvm/ nor in Btw the series still does not include the move of TCGCPUOps to a tcg CPU class accel in tcg/, if ok with you all I would do it in a later series, but let me know if you'd like it here instead. After this series, there is still: cpu class code, cpu-* machine.c arch_dump.c cpu_models* cpu_features* helper.c diag.c interrupt.c ioinst.c mmu_helper.c [ part of this could be still split between tcg/ and kvm/ but it is not a clear call] sigp.c [ same here, could be investigated for further split, but likely common parts would remain here] Many of these items match the S390 KVM CPUs section, which in some cases should probably instead be more in the general section: S390 KVM CPUs M: Halil Pasic <pasic@linux.ibm.com> M: Cornelia Huck <cohuck@redhat.com> M: Christian Borntraeger <borntraeger@de.ibm.com> S: Supported F: target/s390x/kvm/ F: target/s390x/ioinst.[ch] F: target/s390x/machine.c F: target/s390x/sigp.c F: target/s390x/cpu_features*.[ch] F: target/s390x/cpu_models*.[ch] F: hw/s390x/pv.c F: include/hw/s390x/pv.h F: hw/intc/s390_flic.c F: hw/intc/s390_flic_kvm.c F: include/hw/s390x/s390_flic.h F: gdb-xml/s390*.xml T: git https://gitlab.com/cohuck/qemu.git s390-next T: git https://github.com/borntraeger/qemu.git s390-next L: qemu-s390x@nongnu.org > tcg/? It seems that will only be covered by the general s390 > maintainers entry. > >> >> Signed-off-by: Claudio Fontana <cfontana@suse.de> >> --- >> MAINTAINERS | 8 +++----- >> 1 file changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 7de873c9f5..3d738bd4fc 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -315,7 +315,7 @@ S390 TCG CPUs >> M: Richard Henderson <richard.henderson@linaro.org> >> M: David Hildenbrand <david@redhat.com> >> S: Maintained >> -F: target/s390x/ >> +F: target/s390x/tcg >> F: hw/s390x/ > > Unrelated: I'm wondering how much sense it makes to have the whole of > hw/s390x/ under the tcg section... but if the maintainers are not > complaining, I'm happy to leave it there :) > >> F: disas/s390.c >> F: tests/tcg/s390x/ >> @@ -417,14 +417,12 @@ M: Halil Pasic <pasic@linux.ibm.com> >> M: Cornelia Huck <cohuck@redhat.com> >> M: Christian Borntraeger <borntraeger@de.ibm.com> >> S: Supported >> -F: target/s390x/kvm.c >> -F: target/s390x/kvm_s390x.h >> -F: target/s390x/kvm-stub.c >> +F: target/s390x/kvm/ >> F: target/s390x/ioinst.[ch] >> F: target/s390x/machine.c >> F: target/s390x/sigp.c >> F: target/s390x/cpu_features*.[ch] >> -F: target/s390x/cpu_models.[ch] >> +F: target/s390x/cpu_models*.[ch] >> F: hw/s390x/pv.c >> F: include/hw/s390x/pv.h >> F: hw/intc/s390_flic.c > > Let me know if you need further changes here, or if they should be in a separate context. Thanks! Claudio
diff --git a/MAINTAINERS b/MAINTAINERS index 7de873c9f5..3d738bd4fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -315,7 +315,7 @@ S390 TCG CPUs M: Richard Henderson <richard.henderson@linaro.org> M: David Hildenbrand <david@redhat.com> S: Maintained -F: target/s390x/ +F: target/s390x/tcg F: hw/s390x/ F: disas/s390.c F: tests/tcg/s390x/ @@ -417,14 +417,12 @@ M: Halil Pasic <pasic@linux.ibm.com> M: Cornelia Huck <cohuck@redhat.com> M: Christian Borntraeger <borntraeger@de.ibm.com> S: Supported -F: target/s390x/kvm.c -F: target/s390x/kvm_s390x.h -F: target/s390x/kvm-stub.c +F: target/s390x/kvm/ F: target/s390x/ioinst.[ch] F: target/s390x/machine.c F: target/s390x/sigp.c F: target/s390x/cpu_features*.[ch] -F: target/s390x/cpu_models.[ch] +F: target/s390x/cpu_models*.[ch] F: hw/s390x/pv.c F: include/hw/s390x/pv.h F: hw/intc/s390_flic.c
After the reshuffling, update MAINTAINERS accordingly. Make use of the new directories: target/s390x/kvm/ target/s390x/tcg/ Signed-off-by: Claudio Fontana <cfontana@suse.de> --- MAINTAINERS | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)