| Message ID | 20210423203959.78275-1-imp@bsdimp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [PULL,01/24] bsd-user: whitespace changes | expand |
On 4/23/21 1:39 PM, imp@bsdimp.com wrote: > From: Warner Losh <imp@bsdimp.com> > > Signed-off-by: Warner Losh <imp@bsdimp.com> > --- > bsd-user/qemu.h | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h > index b836b603af..3480db890d 100644 > --- a/bsd-user/qemu.h > +++ b/bsd-user/qemu.h > @@ -71,7 +71,7 @@ struct image_info { > > struct sigqueue { > struct sigqueue *next; > - //target_siginfo_t info; > + /* target_siginfo_t info; */ > }; Ack. > @@ -193,9 +193,11 @@ extern int do_strace; > /* signal.c */ > void process_pending_signals(CPUArchState *cpu_env); > void signal_init(void); > -//int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info); > -//void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info); > -//void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo); > +/* > + * int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info); > + * void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info); > + * void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo); > + */ These should probably be deleted with the #if 0 code that references them. r~
On Fri, Apr 23, 2021 at 5:06 PM Richard Henderson < richard.henderson@linaro.org> wrote: > On 4/23/21 1:39 PM, imp@bsdimp.com wrote: > > From: Warner Losh <imp@bsdimp.com> > > > > Signed-off-by: Warner Losh <imp@bsdimp.com> > > --- > > bsd-user/qemu.h | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h > > index b836b603af..3480db890d 100644 > > --- a/bsd-user/qemu.h > > +++ b/bsd-user/qemu.h > > @@ -71,7 +71,7 @@ struct image_info { > > > > struct sigqueue { > > struct sigqueue *next; > > - //target_siginfo_t info; > > + /* target_siginfo_t info; */ > > }; > > Ack. > > > @@ -193,9 +193,11 @@ extern int do_strace; > > /* signal.c */ > > void process_pending_signals(CPUArchState *cpu_env); > > void signal_init(void); > > -//int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info); > > -//void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t > *info); > > -//void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t > *tinfo); > > +/* > > + * int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info); > > + * void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t > *info); > > + * void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t > *tinfo); > > + */ > > These should probably be deleted with the #if 0 code that references them. > OK. Sold. Warner > > r~ >
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h index b836b603af..3480db890d 100644 --- a/bsd-user/qemu.h +++ b/bsd-user/qemu.h @@ -71,7 +71,7 @@ struct image_info { struct sigqueue { struct sigqueue *next; - //target_siginfo_t info; + /* target_siginfo_t info; */ }; struct emulated_sigtable { @@ -193,9 +193,11 @@ extern int do_strace; /* signal.c */ void process_pending_signals(CPUArchState *cpu_env); void signal_init(void); -//int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info); -//void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info); -//void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo); +/* + * int queue_signal(CPUArchState *env, int sig, target_siginfo_t *info); + * void host_to_target_siginfo(target_siginfo_t *tinfo, const siginfo_t *info); + * void target_to_host_siginfo(siginfo_t *info, const target_siginfo_t *tinfo); + */ long do_sigreturn(CPUArchState *env); long do_rt_sigreturn(CPUArchState *env); abi_long do_sigaltstack(abi_ulong uss_addr, abi_ulong uoss_addr, abi_ulong sp);