Message ID | 20210426193520.4115528-2-philmd@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | hw/nvram/fw_cfg: Do not build device if not needed (Spring cleanup) | expand |
On 04/26/21 21:35, Philippe Mathieu-Daudé wrote: > User emulation or tools don't use / require the fw_cfg device. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > stubs/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/stubs/meson.build b/stubs/meson.build > index be6f6d609e5..4ff36401cf9 100644 > --- a/stubs/meson.build > +++ b/stubs/meson.build > @@ -12,7 +12,6 @@ > stub_ss.add(files('dump.c')) > stub_ss.add(files('error-printf.c')) > stub_ss.add(files('fdset.c')) > -stub_ss.add(files('fw_cfg.c')) > stub_ss.add(files('gdbstub.c')) > stub_ss.add(files('get-vm-name.c')) > stub_ss.add(when: 'CONFIG_LINUX_IO_URING', if_true: files('io_uring.c')) > @@ -49,6 +48,7 @@ > stub_ss.add(files('replay-tools.c')) > endif > if have_system > + stub_ss.add(files('fw_cfg.c')) > stub_ss.add(files('semihost.c')) > stub_ss.add(files('xen-hw-stub.c')) > else > The intent is valid and the implementation looks plausible. Acked-by: Laszlo Ersek <lersek@redhat.com>
diff --git a/stubs/meson.build b/stubs/meson.build index be6f6d609e5..4ff36401cf9 100644 --- a/stubs/meson.build +++ b/stubs/meson.build @@ -12,7 +12,6 @@ stub_ss.add(files('dump.c')) stub_ss.add(files('error-printf.c')) stub_ss.add(files('fdset.c')) -stub_ss.add(files('fw_cfg.c')) stub_ss.add(files('gdbstub.c')) stub_ss.add(files('get-vm-name.c')) stub_ss.add(when: 'CONFIG_LINUX_IO_URING', if_true: files('io_uring.c')) @@ -49,6 +48,7 @@ stub_ss.add(files('replay-tools.c')) endif if have_system + stub_ss.add(files('fw_cfg.c')) stub_ss.add(files('semihost.c')) stub_ss.add(files('xen-hw-stub.c')) else
User emulation or tools don't use / require the fw_cfg device. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- stubs/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)