diff mbox series

[v2,1/8] qemu-edid: use qemu_edid_size()

Message ID 20210427150824.638359-2-kraxel@redhat.com (mailing list archive)
State New, archived
Headers show
Series edid: windows fixes | expand

Commit Message

Gerd Hoffmann April 27, 2021, 3:08 p.m. UTC
So we only write out that part of the edid blob
which has been filled with data.
Also use a larger buffer for the blob.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-edid.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Marc-André Lureau April 27, 2021, 3:53 p.m. UTC | #1
On Tue, Apr 27, 2021 at 7:15 PM Gerd Hoffmann <kraxel@redhat.com> wrote:

> So we only write out that part of the edid blob
> which has been filled with data.
> Also use a larger buffer for the blob.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
>  qemu-edid.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-edid.c b/qemu-edid.c
> index 1cd6a9517238..c3a9fba10dc4 100644
> --- a/qemu-edid.c
> +++ b/qemu-edid.c
> @@ -41,7 +41,8 @@ static void usage(FILE *out)
>  int main(int argc, char *argv[])
>  {
>      FILE *outfile = NULL;
> -    uint8_t blob[256];
> +    uint8_t blob[512];
> +    size_t size;
>      uint32_t dpi = 100;
>      int rc;
>
> @@ -119,7 +120,8 @@ int main(int argc, char *argv[])
>
>      memset(blob, 0, sizeof(blob));
>      qemu_edid_generate(blob, sizeof(blob), &info);
> -    fwrite(blob, sizeof(blob), 1, outfile);
> +    size = qemu_edid_size(blob);
> +    fwrite(blob, size, 1, outfile);
>      fflush(outfile);
>
>      exit(0);
> --
> 2.30.2
>
>
>
diff mbox series

Patch

diff --git a/qemu-edid.c b/qemu-edid.c
index 1cd6a9517238..c3a9fba10dc4 100644
--- a/qemu-edid.c
+++ b/qemu-edid.c
@@ -41,7 +41,8 @@  static void usage(FILE *out)
 int main(int argc, char *argv[])
 {
     FILE *outfile = NULL;
-    uint8_t blob[256];
+    uint8_t blob[512];
+    size_t size;
     uint32_t dpi = 100;
     int rc;
 
@@ -119,7 +120,8 @@  int main(int argc, char *argv[])
 
     memset(blob, 0, sizeof(blob));
     qemu_edid_generate(blob, sizeof(blob), &info);
-    fwrite(blob, sizeof(blob), 1, outfile);
+    size = qemu_edid_size(blob);
+    fwrite(blob, size, 1, outfile);
     fflush(outfile);
 
     exit(0);