From patchwork Wed May 5 04:58:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li Qiang X-Patchwork-Id: 12239081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27F38C43460 for ; Wed, 5 May 2021 05:15:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EC82613C1 for ; Wed, 5 May 2021 05:15:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EC82613C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1le9sr-0007RM-IW for qemu-devel@archiver.kernel.org; Wed, 05 May 2021 01:15:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le9rc-00067n-Hq for qemu-devel@nongnu.org; Wed, 05 May 2021 01:14:24 -0400 Received: from m12-16.163.com ([220.181.12.16]:58169) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1le9rY-00017G-Fw for qemu-devel@nongnu.org; Wed, 05 May 2021 01:14:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=zlCFF 1m7rXQZjXsw0wpx6URXzl2KvVLjDHEWjVRKgC4=; b=a6M5PbwU0Mk3EgYMM3QWG sDascPIvCFTIcjTOOaho7D6BdsGrd23PQ5ky9bFTZXOpk9MKr7Xp6QkFLI7vrcjZ DcIoEBzfQQM1pjg+ot0vBe/UNM/OfXzWkSd6HCZ+MJjIBXMyXMHzsfkXMaO+Ili7 MV4N3ogf36QNiIRw+4mfbk= Received: from ubuntu.localdomain (unknown [36.22.237.185]) by smtp12 (Coremail) with SMTP id EMCowACXET7zJZJg8VpupQ--.18216S5; Wed, 05 May 2021 12:58:29 +0800 (CST) From: Li Qiang To: marcandre.lureau@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org Subject: [PATCH 1/7] vhost-user-gpu: fix memory disclosure in virgl_cmd_get_capset_info Date: Tue, 4 May 2021 21:58:18 -0700 Message-Id: <20210505045824.33880-2-liq3ea@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210505045824.33880-1-liq3ea@163.com> References: <20210505045824.33880-1-liq3ea@163.com> MIME-Version: 1.0 X-CM-TRANSID: EMCowACXET7zJZJg8VpupQ--.18216S5 X-Coremail-Antispam: 1Uf129KBjvdXoW5Kry3Cw17Ar1DGF18Xr4fXwb_yoWxWFb_ZF 1FyFn7AF4DWrW0krs8Zw4rJ3yavrWYyFsayFnakr1xXFyYkw15Xwn3t34kJ3yfuw43GF4D AFy0yw4rGa1j9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUboGQPUUUUU== X-Originating-IP: [36.22.237.185] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbB8QWJbV2MZ6UWWQAAsM Received-SPF: pass client-ip=220.181.12.16; envelope-from=liq3ea@163.com; helo=m12-16.163.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Otherwise some of the 'resp' will be leaked to guest. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/virgl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c index 9e6660c7ab..6a332d601f 100644 --- a/contrib/vhost-user-gpu/virgl.c +++ b/contrib/vhost-user-gpu/virgl.c @@ -128,6 +128,7 @@ virgl_cmd_get_capset_info(VuGpu *g, VUGPU_FILL_CMD(info); + memset(&resp, 0, sizeof(resp)); if (info.capset_index == 0) { resp.capset_id = VIRTIO_GPU_CAPSET_VIRGL; virgl_renderer_get_cap_set(resp.capset_id,