mbox

[PULL,0/7] s390x update

Message ID 20210506154423.459930-1-cohuck@redhat.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://gitlab.com/cohuck/qemu.git tags/s390x-20210506

Message

Cornelia Huck May 6, 2021, 3:44 p.m. UTC
The following changes since commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac:

  Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-05 13:52:00 +0100)

are available in the Git repository at:

  https://gitlab.com/cohuck/qemu.git tags/s390x-20210506

for you to fetch changes up to 2337ca0dd1747851cf596e90a2360578e3f9a473:

  vfio-ccw: Attempt to clean up all IRQs on error (2021-05-06 13:49:07 +0200)

----------------------------------------------------------------
s390x fixes and cleanups; also related fixes in xtensa and arm

----------------------------------------------------------------

Eric Farman (2):
  vfio-ccw: Permit missing IRQs
  vfio-ccw: Attempt to clean up all IRQs on error

Ilya Leoshkevich (4):
  target/s390x: Fix translation exception on illegal instruction
  target/arm: Make sure that commpage's tb->size != 0
  target/xtensa: Make sure that tb->size != 0
  accel/tcg: Assert that tb->size != 0 after translation

Philippe Mathieu-Daudé (1):
  hw/s390x/ccw: Register qbus type in abstract TYPE_CCW_DEVICE parent

 accel/tcg/translate-all.c |  1 +
 hw/s390x/3270-ccw.c       |  1 -
 hw/s390x/ccw-device.c     |  1 +
 hw/s390x/ccw-device.h     |  1 +
 hw/s390x/s390-ccw.c       |  2 --
 hw/s390x/virtio-ccw.c     |  1 -
 hw/vfio/ccw.c             | 18 +++++++++++-------
 target/arm/translate.c    |  2 ++
 target/s390x/translate.c  | 16 +++++++++++-----
 target/xtensa/translate.c |  3 +++
 10 files changed, 30 insertions(+), 16 deletions(-)

Comments

Peter Maydell May 11, 2021, 12:02 p.m. UTC | #1
On Thu, 6 May 2021 at 16:44, Cornelia Huck <cohuck@redhat.com> wrote:
>
> The following changes since commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac:
>
>   Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-05 13:52:00 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/cohuck/qemu.git tags/s390x-20210506
>
> for you to fetch changes up to 2337ca0dd1747851cf596e90a2360578e3f9a473:
>
>   vfio-ccw: Attempt to clean up all IRQs on error (2021-05-06 13:49:07 +0200)
>
> ----------------------------------------------------------------
> s390x fixes and cleanups; also related fixes in xtensa and arm
>
> ----------------------------------------------------------------
>
> Eric Farman (2):
>   vfio-ccw: Permit missing IRQs
>   vfio-ccw: Attempt to clean up all IRQs on error
>
> Ilya Leoshkevich (4):
>   target/s390x: Fix translation exception on illegal instruction
>   target/arm: Make sure that commpage's tb->size != 0
>   target/xtensa: Make sure that tb->size != 0
>   accel/tcg: Assert that tb->size != 0 after translation
>
> Philippe Mathieu-Daudé (1):
>   hw/s390x/ccw: Register qbus type in abstract TYPE_CCW_DEVICE parent

This asserts running x86-64 linux-user:

/home/petmay01/linaro/qemu-for-merges/build/all-linux-static/x86_64-linux-user/qemu-x86_64
-L ./gnemul/qemu-x86_64 x86_64/ls -l dummyfile
qemu-x86_64: ../../accel/tcg/translate-all.c:1915: tb_gen_code:
Assertion `tb->size != 0' failed.
qemu-x86_64: ../../accel/tcg/cpu-exec.c:766: cpu_exec: Assertion
`!have_mmap_lock()' failed.
Makefile:6: recipe for target 'test' failed

This is for the TARGET_VSYSCALL_PAGE case in i386_tr_translate_insn(),
which generates a zero-size TB.

thanks
-- PMM
Cornelia Huck May 11, 2021, 12:13 p.m. UTC | #2
On Tue, 11 May 2021 13:02:08 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:

> On Thu, 6 May 2021 at 16:44, Cornelia Huck <cohuck@redhat.com> wrote:
> >
> > The following changes since commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac:
> >
> >   Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-05 13:52:00 +0100)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/cohuck/qemu.git tags/s390x-20210506
> >
> > for you to fetch changes up to 2337ca0dd1747851cf596e90a2360578e3f9a473:
> >
> >   vfio-ccw: Attempt to clean up all IRQs on error (2021-05-06 13:49:07 +0200)
> >
> > ----------------------------------------------------------------
> > s390x fixes and cleanups; also related fixes in xtensa and arm
> >
> > ----------------------------------------------------------------
> >
> > Eric Farman (2):
> >   vfio-ccw: Permit missing IRQs
> >   vfio-ccw: Attempt to clean up all IRQs on error
> >
> > Ilya Leoshkevich (4):
> >   target/s390x: Fix translation exception on illegal instruction
> >   target/arm: Make sure that commpage's tb->size != 0
> >   target/xtensa: Make sure that tb->size != 0
> >   accel/tcg: Assert that tb->size != 0 after translation
> >
> > Philippe Mathieu-Daudé (1):
> >   hw/s390x/ccw: Register qbus type in abstract TYPE_CCW_DEVICE parent  
> 
> This asserts running x86-64 linux-user:
> 
> /home/petmay01/linaro/qemu-for-merges/build/all-linux-static/x86_64-linux-user/qemu-x86_64
> -L ./gnemul/qemu-x86_64 x86_64/ls -l dummyfile
> qemu-x86_64: ../../accel/tcg/translate-all.c:1915: tb_gen_code:
> Assertion `tb->size != 0' failed.
> qemu-x86_64: ../../accel/tcg/cpu-exec.c:766: cpu_exec: Assertion
> `!have_mmap_lock()' failed.
> Makefile:6: recipe for target 'test' failed
> 
> This is for the TARGET_VSYSCALL_PAGE case in i386_tr_translate_insn(),
> which generates a zero-size TB.

Ilya, can you please take a look?