diff mbox series

[v7,06/10] KVM: Simplify dirty log sync in kvm_set_phys_mem

Message ID 20210506160549.130416-7-peterx@redhat.com (mailing list archive)
State New, archived
Headers show
Series KVM: Dirty ring support (QEMU part) | expand

Commit Message

Peter Xu May 6, 2021, 4:05 p.m. UTC
kvm_physical_sync_dirty_bitmap() on the whole section is inaccurate, because
the section can be a superset of the memslot that we're working on.  The result
is that if the section covers multiple kvm memslots, we could be doing the
synchronization for multiple times for each kvmslot in the section.

With the two helpers that we just introduced, it's very easy to do it right now
by calling the helpers.

Signed-off-by: Peter Xu <peterx@redhat.com>
 accel/kvm/kvm-all.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 1025701f557..4b786240a04 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -1161,7 +1161,8 @@  static void kvm_set_phys_mem(KVMMemoryListener *kml,
                 goto out;
             if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
-                kvm_physical_sync_dirty_bitmap(kml, section);
+                kvm_slot_get_dirty_log(kvm_state, mem);
+                kvm_slot_sync_dirty_pages(mem);
             /* unregister the slot */