diff mbox series

[PULL,06/20] bsd-user: style tweak: move extern to header file

Message ID 20210512171720.46744-7-imp@bsdimp.com (mailing list archive)
State New, archived
Headers show
Series [PULL,01/20] bsd-user: whitespace changes | expand

Commit Message

Warner Losh May 12, 2021, 5:17 p.m. UTC
extern char **environ has no standard home, so move the declaration from the .c
file to a handy .h file. Since this is a standard, old-school UNIX interface
dating from the 5th edition, it's not quite the same issue that the rule is
supposed to protect against, though.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Warner Losh <imp@bsdimp.com>
 bsd-user/main.c | 1 -
 bsd-user/qemu.h | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/bsd-user/main.c b/bsd-user/main.c
index cd1c26516b..71bfe17f38 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -47,7 +47,6 @@  unsigned long reserved_va;
 static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
 const char *qemu_uname_release;
-extern char **environ;
 enum BSDType bsd_type;
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 7ccc8ad397..5a82722281 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -27,6 +27,8 @@ 
 #include "exec/user/abitypes.h"
+extern char **environ;
 enum BSDType {