| Message ID | 20210513163858.3928976-10-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw: Various Kconfig fixes | expand |
Forgot to Cc Alex. On 5/13/21 6:38 PM, Philippe Mathieu-Daudé wrote: > Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to > shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol > which selects SEMIHOSTING. > > Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING, > they don't need to select SEMIHOSTING manually. Simplify. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > default-configs/devices/arm-softmmu.mak | 1 - > default-configs/devices/riscv32-softmmu.mak | 1 - > default-configs/devices/riscv64-softmmu.mak | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/devices/arm-softmmu.mak > index 0500156a0c7..341d439de6f 100644 > --- a/default-configs/devices/arm-softmmu.mak > +++ b/default-configs/devices/arm-softmmu.mak > @@ -41,6 +41,5 @@ CONFIG_MICROBIT=y > CONFIG_FSL_IMX25=y > CONFIG_FSL_IMX7=y > CONFIG_FSL_IMX6UL=y > -CONFIG_SEMIHOSTING=y > CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y > CONFIG_ALLWINNER_H3=y > diff --git a/default-configs/devices/riscv32-softmmu.mak b/default-configs/devices/riscv32-softmmu.mak > index d847bd5692e..5c9ad2590ef 100644 > --- a/default-configs/devices/riscv32-softmmu.mak > +++ b/default-configs/devices/riscv32-softmmu.mak > @@ -3,7 +3,6 @@ > # Uncomment the following lines to disable these optional devices: > # > #CONFIG_PCI_DEVICES=n > -CONFIG_SEMIHOSTING=y > CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y > > # Boards: > diff --git a/default-configs/devices/riscv64-softmmu.mak b/default-configs/devices/riscv64-softmmu.mak > index bc69301fa4a..8a92f0a2c74 100644 > --- a/default-configs/devices/riscv64-softmmu.mak > +++ b/default-configs/devices/riscv64-softmmu.mak > @@ -3,7 +3,6 @@ > # Uncomment the following lines to disable these optional devices: > # > #CONFIG_PCI_DEVICES=n > -CONFIG_SEMIHOSTING=y > CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y > > # Boards: >
On Fri, May 14, 2021 at 12:58 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to > shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol > which selects SEMIHOSTING. > > Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING, > they don't need to select SEMIHOSTING manually. Simplify. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > default-configs/devices/arm-softmmu.mak | 1 - > default-configs/devices/riscv32-softmmu.mak | 1 - > default-configs/devices/riscv64-softmmu.mak | 1 - > 3 files changed, 3 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Fri, May 14, 2021 at 10:53 AM Bin Meng <bmeng.cn@gmail.com> wrote: > > On Fri, May 14, 2021 at 12:58 AM Philippe Mathieu-Daudé > <philmd@redhat.com> wrote: > > > > Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to typo: Commit > > shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol > > which selects SEMIHOSTING. > > > > Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING, > > they don't need to select SEMIHOSTING manually. Simplify. > > > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > --- > > default-configs/devices/arm-softmmu.mak | 1 - > > default-configs/devices/riscv32-softmmu.mak | 1 - > > default-configs/devices/riscv64-softmmu.mak | 1 - > > 3 files changed, 3 deletions(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/devices/arm-softmmu.mak index 0500156a0c7..341d439de6f 100644 --- a/default-configs/devices/arm-softmmu.mak +++ b/default-configs/devices/arm-softmmu.mak @@ -41,6 +41,5 @@ CONFIG_MICROBIT=y CONFIG_FSL_IMX25=y CONFIG_FSL_IMX7=y CONFIG_FSL_IMX6UL=y -CONFIG_SEMIHOSTING=y CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y CONFIG_ALLWINNER_H3=y diff --git a/default-configs/devices/riscv32-softmmu.mak b/default-configs/devices/riscv32-softmmu.mak index d847bd5692e..5c9ad2590ef 100644 --- a/default-configs/devices/riscv32-softmmu.mak +++ b/default-configs/devices/riscv32-softmmu.mak @@ -3,7 +3,6 @@ # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=n -CONFIG_SEMIHOSTING=y CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y # Boards: diff --git a/default-configs/devices/riscv64-softmmu.mak b/default-configs/devices/riscv64-softmmu.mak index bc69301fa4a..8a92f0a2c74 100644 --- a/default-configs/devices/riscv64-softmmu.mak +++ b/default-configs/devices/riscv64-softmmu.mak @@ -3,7 +3,6 @@ # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=n -CONFIG_SEMIHOSTING=y CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y # Boards:
Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol which selects SEMIHOSTING. Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING, they don't need to select SEMIHOSTING manually. Simplify. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- default-configs/devices/arm-softmmu.mak | 1 - default-configs/devices/riscv32-softmmu.mak | 1 - default-configs/devices/riscv64-softmmu.mak | 1 - 3 files changed, 3 deletions(-)