From patchwork Thu May 13 16:38:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12255981 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB4CC433B4 for ; Thu, 13 May 2021 16:57:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B64B613CA for ; Thu, 13 May 2021 16:57:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B64B613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEem-0005DT-K7 for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 12:57:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMu-0002Mu-7y for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEMl-0000kJ-1P for qemu-devel@nongnu.org; Thu, 13 May 2021 12:39:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=SpOF1dwBqbrBOfue/VffN3phkJPRIRmKKNmheNSzYZkrBCiEl84diY4wx3Uz6BT5dYVYtH RJ6eFh9ZgkSMVoJ4GA4BK0kXgvxTiJY2FBFj73lzCAd6OWu5iKLFzH9EeP9J/63SBvFMdh kORqyeY0zduFTAw01kW7nZULQoWZm8M= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-K-BANdI1NCukM5dvVQphfQ-1; Thu, 13 May 2021 12:39:11 -0400 X-MC-Unique: K-BANdI1NCukM5dvVQphfQ-1 Received: by mail-ed1-f71.google.com with SMTP id y17-20020a0564023591b02903886c26ada4so14943576edc.5 for ; Thu, 13 May 2021 09:39:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=C/+mnddZD0Jt5VVwdfQpw9V4xXvUj1U/BsNzceRSystrPClZnBCnLC12Z3XXdd6WQw V5oTO3B90+HGAGe3cjFcM+x57LRQenE0Xp2Jc+ZAhh+gwFgaMqqQytotNnDyi7hnGxF3 wZMEtoWMiVZH15TWfRC4JUdB6BcILqLjAhhg9e4uCCn35MeSQo12rfMY3C35vlDGG3/r vmucUas0l5schvH+SsZvvwp89iJ8EJJ4YshZNtpKyJ8qOg1jqSSrByk5dWq1Y6BFKxK2 652st7mWfGbQN3S5oUL+WxnpufY1pi0wCZ8b4G4RyOrWrkypxm2ij7DogsQMf6Nlx/uz fgzA== X-Gm-Message-State: AOAM530omYf0rzBpLt1LfrVftJeHEcaa120Rlt6Xp/0Yt7KhnrY2W58r FmwwPa+C3w6u4L440JJjvvd1ougCZJKJCHqsitEFGHC1xKHOZ6x8ERmRPlFWv4W/IRByC+mVyfR beTslBui1x8T3a1Hxrr4fMGA5htUffWQKDou4uyrVUEVFCYVtuaypIHKtBVf8Y7wK X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659188ejb.375.1620923949810; Thu, 13 May 2021 09:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3rRwCF9pZ71vFd93cXhzmvhSqn1g1AzCJRzfmiTLGOhSM/2mbCl5wEmp1SgZQMcoMTUp6Wg== X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659173ejb.375.1620923949646; Thu, 13 May 2021 09:39:09 -0700 (PDT) Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id di7sm2695781edb.34.2021.05.13.09.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:09 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV Date: Thu, 13 May 2021 18:38:50 +0200 Message-Id: <20210513163858.3928976-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "open list:IDE" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd_table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_devs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV config IDE_ISA bool